Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): add name suffix #106

Merged
merged 13 commits into from
May 24, 2024
Merged

fix(api): add name suffix #106

merged 13 commits into from
May 24, 2024

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented May 22, 2024

Description

Adjusting parameter names in accordance with the recommendations

Why do we need it, and what problem does it solve?

We must follow the generally accepted recommendations

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

fl64 and others added 13 commits May 20, 2024 18:25
@fl64
refactor(crd): fix crd params and add name suffixes
fdc4cd0 
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@fl64
refactor(crd): update docs
a7944b1 
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@fl64
refactor(crd): fix lint
d456f3e 
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@fl64
refactor(crd): rename storageClass param
b5b2bd3 
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@fl64
refactor(crd): rename virtualMachine param
1c859f6 
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@Isteb4k @fl64
feat(api): rename resource references
efe6909 
Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@fl64
docs(vm): update
93456c9 
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@fl64
docs: update
6f8f66b 
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@fl64
docs(vm): update en crd
78faf58 
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@fl64
feat(test) fix indents in ru crds
eef0670 
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@Isteb4k @fl64
test(vm): fix vm matching
322f4fc 
Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@Isteb4k @fl64
docs(api): fix linter warnings
847eaff 
Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@fl64
feat(module): rename core resources (#104)
ff32d55 
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@Isteb4k Isteb4k added the validation/skip/doc_changes Skip doc changes validation label May 22, 2024
@Isteb4k Isteb4k requested a review from fl64 May 22, 2024 11:19
@fl64
Copy link
Member

fl64 commented May 23, 2024

I think the type of PR should be "fix" :)

@fl64 fl64 changed the title feat(api): add name suffix fix(api): add name suffix May 24, 2024
@fl64 fl64 merged commit 7c7fb60 into main May 24, 2024
33 of 35 checks passed
@fl64 fl64 deleted the feat/api/add-name-suffix branch May 24, 2024 09:39
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request May 24, 2024
Merged
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fl64 fl64 fl64 approved these changes

Assignees

@Isteb4k Isteb4k

Labels
validation/skip/doc_changes Skip doc changes validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isteb4k @fl64