feat(vdsnapshot): add the new controller for the virtual disk snapshot #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
force-pushed
the
feat/vd/snapshot
branch
2 times, most recently
from
17a1a51
to
54e8883
Compare
Isteb4k
force-pushed
the
feat/vd/snapshot
branch
26 times, most recently
from
46c83a5
to
2a6c644
Compare
Isteb4k
force-pushed
the
feat/vd/snapshot
branch
6 times, most recently
from
1d699e3
to
cdcf91d
Compare
yaroslavborbat
requested changes
Aug 27, 2024
images/virtualization-artifact/pkg/controller/service/snapshot_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/snapshot_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/watcher/vdsnapshot_watcher.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/snapshotting.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/snapshotting.go
Show resolved
Hide resolved
Isteb4k
force-pushed
the
feat/vd/snapshot
branch
from
1797d13
to
d78b398
Compare
fl64
previously approved these changes
Aug 29, 2024
Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com> Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
Isteb4k
force-pushed
the
feat/vd/snapshot
branch
2 times, most recently
from
4fe84ee
to
dcd5096
Compare
Isteb4k
force-pushed
the
feat/vd/snapshot
branch
2 times, most recently
from
7c68d53
to
fbc2b57
Compare
yaroslavborbat
previously approved these changes
Aug 29, 2024
Isteb4k
force-pushed
the
feat/vd/snapshot
branch
from
fbc2b57
to
d5f5b43
Compare
Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
Isteb4k
force-pushed
the
feat/vd/snapshot
branch
from
d5f5b43
to
fb0cbed
Compare
LopatinDmitr
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VirtualDiskSnapshotReadyandVirtualDiskReadyFilesystemReadyfor the virtual machineSnapshottingfor the diskChecklist