Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vm): add metrics #333

Merged
merged 27 commits into from
Sep 10, 2024
Merged

feat(vm): add metrics #333

merged 27 commits into from
Sep 10, 2024

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Sep 2, 2024 •
edited
Loading

Description

Add new metrics

# VM core count
d8_virtualization_virtualmachine_configuration_cpu_cores = 1 ... 1024
# VM coreFraction param without % 
d8_virtualization_virtualmachine_configuration_cpu_core_fraction = 5 10 25 50 100

# VM requested cores like kube_pod_container_resource_requests{resource="cpu"}
d8_virtualization_virtualmachine_configuration_cpu_requested_cores = 0.1 0.25 1 10 100 ...
# VM system overhead (vmpod cores - vm cores) like kube_pod_container_resource_requests{resource="cpu"}
d8_virtualization_virtualmachine_configuration_cpu_runtime_overhead = 0.1 0.25 1 10 100 ...

# VM memory size in bytes like kube_pod_container_resource_requests{resource="memory"}
d8_virtualization_virtualmachine_configuration_memory_size = bytes
# VM memory overhead in bytes (vmpod mem - vm mem) like kube_pod_container_resource_requests{resource="memory"}
d8_virtualization_virtualmachine_configuration_memory_runtime_overhead = bytes

# AwaitingRestartToApplyConfiguration condition (true | false)
d8_virtualization_virtualmachine_awaiting_restart_to_apply_configuration = 0 | 1
# ConfigurationApplied condition (true | false)
d8_virtualization_virtualmachine_configuration_applied = 0 | 1
# .spec.runPolicy (true | false)
d8_virtualization_virtualmachine_configuration_run_policy{run_policy="AlwaysOn|..."} = 0|1
# VM Pod name (0 - inactive | 1 - active)
d8_virtualization_virtualmachine_pod{pod_name="current-pod-name"} = 0 | 1

Base labels
{name="vmname" namespace="ns" node="vmnode" uid="uid"}

Why do we need it, and what problem does it solve?

we need more metrics

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@yaroslavborbat yaroslavborbat marked this pull request as ready for review September 3, 2024 16:17
@yaroslavborbat yaroslavborbat added the validation/skip/doc_changes Skip doc changes validation label Sep 4, 2024
@diafour
Copy link
Member

diafour commented Sep 4, 2024

Let's rename virtualmachine.yaml into virtualmachines.yaml in a separate PR and merge it to main to see difference between hand-made and generated CRD in this PR.

fl64
fl64 requested changes Sep 5, 2024
View reviewed changes
crds/virtualmachines.yaml Outdated Show resolved Hide resolved
crds/virtualmachines.yaml Outdated Show resolved Hide resolved
crds/virtualmachines.yaml Outdated Show resolved Hide resolved
crds/virtualmachines.yaml Outdated Show resolved Hide resolved
diafour
diafour previously approved these changes Sep 5, 2024
View reviewed changes
@yaroslavborbat yaroslavborbat dismissed stale reviews from Isteb4k and diafour via 83385ee September 5, 2024 13:32
@yaroslavborbat
add
4ecb38a 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
fix empty reasons
e1316cf 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
fix unit scheme
82d9bd9 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
fix
cb2a545 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
fix
e5514d5 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
fix lint
a9051c7 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
add
402fb0c 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
fix
fef811e 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
yaroslavborbat and others added 11 commits September 6, 2024 13:53
@yaroslavborbat
fix yaml
3f20c2f 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
fix
61f6710 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat @diafour
Update api/core/v1alpha2/virtual_machine.go
0ec6401 
Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
@yaroslavborbat @diafour
Update crds/doc-ru-virtualmachineclasses.yaml
519ad28 
Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
@yaroslavborbat @diafour
Update crds/doc-ru-virtualmachines.yaml
e103471 
Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
@yaroslavborbat
resolve commits
ae596fc 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
fix
841dc4f 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
fix
37f5846 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
fix log
570f2de 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
regenerate openapi
aca45b6 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@yaroslavborbat
revert generation crd
2fec6e6 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
fl64
fl64 requested changes Sep 9, 2024
View reviewed changes
crds/virtualmachines.yaml Outdated Show resolved Hide resolved
crds/virtualmachines.yaml Outdated Show resolved Hide resolved
crds/virtualmachines.yaml Outdated Show resolved Hide resolved
crds/virtualmachines.yaml Outdated Show resolved Hide resolved
crds/virtualmachines.yaml Outdated Show resolved Hide resolved
crds/virtualmachines.yaml Outdated Show resolved Hide resolved
crds/virtualmachines.yaml Outdated Show resolved Hide resolved
yaroslavborbat and others added 5 commits September 9, 2024 10:30
@yaroslavborbat @fl64
Update crds/virtualmachines.yaml
6fc0811 
Co-authored-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
@yaroslavborbat @fl64
Update crds/virtualmachines.yaml
fa05b1d 
Co-authored-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
@yaroslavborbat @fl64
Update crds/virtualmachines.yaml
c710816 
Co-authored-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
@yaroslavborbat @fl64
Update crds/virtualmachines.yaml
4e9f868 
Co-authored-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
@yaroslavborbat @fl64
Update crds/virtualmachines.yaml
f6b5199 
Co-authored-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
@yaroslavborbat
fix
286aa2e 
Signed-off-by: yaroslavborbat <yaroslav.752@gmail.com>
@fl64 fl64 merged commit c28df0a into main Sep 10, 2024
10 checks passed
@fl64 fl64 deleted the feat/vm/add-metrics branch September 10, 2024 08:21
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Sep 10, 2024
Merged
universal-itengineer pushed a commit that referenced this pull request Sep 11, 2024
@deckhouse-BOaTswain
chore(main): release 0.13.0 (#311)
41e474c 
Features
api: adjust image size (cbb37c1)
api: set tag for dvcr images (cf71a98)
cdi: remove service-monitor (#328) (621baf2)
controllelr: add gc for resources (#303) (a14f2e8)
controller: add tasks with dlv (#321) (83fa3c6)
cvi: create from vd (#352) (e42e28c)
module: add base control-plane alerts (#345) (c66c4fd)
vd: deny iso source (77bcad1)
vd: override virtualdisk's pvc parameters via StorageClass annotations (#351) (fa37881)
vdsnapshot: add the new controller for the virtual disk snapshot (e813124)
vd: support filesystem mode (#300) (4b147f7)
vd: support filesystem mode (#327) (754c4a7)
vi: add new storage type - kubernetes (#298) (51e2a40)
vi: create from vd (#354) (f4d4b6d)
vm-route-forge: add ebpf route watcher (#292) (ca67190)
vm: add metrics (#333) (c28df0a)
vmclass: size policies vaidation hook (#344) (5f585c4)
vmop: implement conditions, use new reconciler style (#258) (13f6a9d)

Bug Fixes
cvi: fix cleanup for resources (#363) (1f13148)
templates: add missed symbol (#318) (f30cd69)
vd: ensure last transition time for conditions (b39487a)
vd: fix panic if pvc not found (#349) (fd4b0af)
vd: remove pv protection (aa489c4)
vd: set validator warnings instead of errors (b173b08)
vm-route-forge: add check to ensure VM host node is identified (#356) (4077584)
vmbda: fix sa rules (9367162)
vmclass: revert last transition time to condition builder (db3f272)
vm: fix panic with nil labelselector (#355) (8df6c59)
vm: impl delete method for subresource virtualmachine on apiserver (#334) (39c7d65)
vm: sync labels and annos with empty value (#322) (0353618)
eofff pushed a commit that referenced this pull request Sep 18, 2024
@yaroslavborbat
feat(vm): add metrics (#333)
9eef789 
Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>

Add new metrics

# VM core count
d8_virtualization_virtualmachine_configuration_cpu_cores = 1 ... 1024
# VM coreFraction param without %
d8_virtualization_virtualmachine_configuration_cpu_core_fraction = 5 10 25 50 100

# VM requested cores like kube_pod_container_resource_requests{resource="cpu"}
d8_virtualization_virtualmachine_configuration_cpu_requested_cores = 0.1 0.25 1 10 100 ...
# VM system overhead (vmpod cores - vm cores) like kube_pod_container_resource_requests{resource="cpu"}
d8_virtualization_virtualmachine_configuration_cpu_runtime_overhead = 0.1 0.25 1 10 100 ...

# VM memory size in bytes like kube_pod_container_resource_requests{resource="memory"}
d8_virtualization_virtualmachine_configuration_memory_size = bytes
# VM memory overhead in bytes (vmpod mem - vm mem) like kube_pod_container_resource_requests{resource="memory"}
d8_virtualization_virtualmachine_configuration_memory_runtime_overhead = bytes

# AwaitingRestartToApplyConfiguration condition (true | false)
d8_virtualization_virtualmachine_awaiting_restart_to_apply_configuration = 0 | 1
# ConfigurationApplied condition (true | false)
d8_virtualization_virtualmachine_configuration_applied = 0 | 1
# .spec.runPolicy (true | false)
d8_virtualization_virtualmachine_configuration_run_policy{run_policy="AlwaysOn|..."} = 0|1
# VM Pod name (0 - inactive | 1 - active)
d8_virtualization_virtualmachine_pod{pod_name="current-pod-name"} = 0 | 1

Base labels
 {name="vmname" namespace="ns" node="vmnode" uid="uid"}

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
eofff pushed a commit that referenced this pull request Sep 18, 2024
@deckhouse-BOaTswain
chore(main): release 0.13.0 (#311)
69af0af 
Features
api: adjust image size (cbb37c1)
api: set tag for dvcr images (cf71a98)
cdi: remove service-monitor (#328) (621baf2)
controllelr: add gc for resources (#303) (a14f2e8)
controller: add tasks with dlv (#321) (83fa3c6)
cvi: create from vd (#352) (e42e28c)
module: add base control-plane alerts (#345) (c66c4fd)
vd: deny iso source (77bcad1)
vd: override virtualdisk's pvc parameters via StorageClass annotations (#351) (fa37881)
vdsnapshot: add the new controller for the virtual disk snapshot (e813124)
vd: support filesystem mode (#300) (4b147f7)
vd: support filesystem mode (#327) (754c4a7)
vi: add new storage type - kubernetes (#298) (51e2a40)
vi: create from vd (#354) (f4d4b6d)
vm-route-forge: add ebpf route watcher (#292) (ca67190)
vm: add metrics (#333) (c28df0a)
vmclass: size policies vaidation hook (#344) (5f585c4)
vmop: implement conditions, use new reconciler style (#258) (13f6a9d)

Bug Fixes
cvi: fix cleanup for resources (#363) (1f13148)
templates: add missed symbol (#318) (f30cd69)
vd: ensure last transition time for conditions (b39487a)
vd: fix panic if pvc not found (#349) (fd4b0af)
vd: remove pv protection (aa489c4)
vd: set validator warnings instead of errors (b173b08)
vm-route-forge: add check to ensure VM host node is identified (#356) (4077584)
vmbda: fix sa rules (9367162)
vmclass: revert last transition time to condition builder (db3f272)
vm: fix panic with nil labelselector (#355) (8df6c59)
vm: impl delete method for subresource virtualmachine on apiserver (#334) (39c7d65)
vm: sync labels and annos with empty value (#322) (0353618)

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fl64 fl64 fl64 approved these changes

@diafour diafour Awaiting requested review from diafour

@Isteb4k Isteb4k Awaiting requested review from Isteb4k

Assignees

@yaroslavborbat yaroslavborbat

Labels
validation/skip/doc_changes Skip doc changes validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaroslavborbat @diafour @fl64 @Isteb4k