Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vmbda): allow wffc hotplugs #378

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Sep 17, 2024

Description

  1. vmbda condition BlockDeviceReady waits until the disk is wffc or ready, after which it performs a hot plug to the virtual machine (from this moment the disk is considered attached to the virtual machine)
  2. vd does not allow editing the spec if the disk is attached to the virtual machine or Ready
  3. vmbda CRD gen2
  4. vmbda uses condition builder to manage conditions

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@Isteb4k Isteb4k force-pushed the fix/vmbda/allow-wffc-hotplugs branch 7 times, most recently from 8c201e0 to f38b5e1 Compare September 17, 2024 15:19
@Isteb4k Isteb4k marked this pull request as ready for review September 17, 2024 15:33
Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
@Isteb4k Isteb4k merged commit e155f4e into main Sep 18, 2024
10 checks passed
@Isteb4k Isteb4k deleted the fix/vmbda/allow-wffc-hotplugs branch September 18, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants