Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(module): remove builders and artifacts from images_digests.json #379

Merged

Conversation

fl64
Copy link
Member

@fl64 fl64 commented Sep 17, 2024

Description

We don't need base images, builder and artifacts in images_digests.json

Why do we need it, and what problem does it solve?

Reduce the size of transferred data to the customer's container registry

What is the expected result?

Example:

kubectl -n d8-system exec -ti -c deckhouse deploy/deckhouse -- deckhouse-controller global values -o json | jq .modulesImages.digests.virtualization -r           
{
  "cdiApiserver": "sha256:90f7f47801ebe97a8cdf6b147c490c739f04a80a64dbad6def99361e58395101",
  "cdiCloner": "sha256:64bf203e560e4eb0f9a6cd40226131bf15fac98673ddd9521f6ebe24de570378",
  "cdiController": "sha256:6373e5c470f7fd24918ed2aee976c35ea79ec10864ee9be10ee931f605ccdaf6",
  "cdiImporter": "sha256:956132fffe289407cdbb48cbe5c87bbf1474b54a77d5668dfc1b8d43635e61b9",
  "cdiOperator": "sha256:f82083faf236e2a0d8b8c777d3aedaabdc7634a643bf44077ba54a7ba19e36ee",
  "cdiUploadproxy": "sha256:d1b2a6f534c3dd3151dfd2c94172a778a65a70cd8d715f5483f0eb2caf2c6549",
  "cdiUploadserver": "sha256:1266830d2e0f985e75a51628d061bb726e0f58c8b26ba85ed9c9b883129c8cd8",
  "dvcr": "sha256:607b137c0ad48b6eb8cca415601ad5c4a86eb8037fa2e3eed98a27f32d4b3e2d",
  "dvcrArtifact": "sha256:a198ddc15e0a406757df8d6ab3751b5d2d22ccb7c4bdf44ed53ebf6dddfaac4d",
  "dvcrImporter": "sha256:f308b5a6ebdaef58bc87075950b123c0b80f88da5df535c9a498cc992dffc2f2",
  "dvcrUploader": "sha256:019a7d6c7b0e75ccc192e28d6efb06ccc0a952bd844319344d1698aafe92d127",
  "kubeApiProxy": "sha256:816bfc142ada3dcc4bb5a11379caa8cb6ada002ea6a19dd5af56e625943fff8d",
  "libguestfs": "sha256:763a72a6a121a57444798a6eb493e651956de6b95a4ca7c73ef01b0bec0fd7a8",
  "preDeleteHook": "sha256:568bb70a6d1dfae014d972d41b3ab7cc300324e667bffc0a1eab3e2ed20b2d11",
  "virtApi": "sha256:2b351147488f16e1a71473eff5ecb32e1e2c8c152923964e6bb016cfeb8708ad",
  "virtController": "sha256:272bcc05bc2c951d484872378ef710d06e2de15b56d9b04097d7cd68117f7c3c",
  "virtExportproxy": "sha256:a7c77fdd9087bcc7e207562e1163a883aa3ab50997ae2adb69414c7e755c5d97",
  "virtExportserver": "sha256:9214502ceccef14d8e193c6a4d4b3631f4b7a4a257b3e8d5af021b7abb476794",
  "virtHandler": "sha256:9103fdf680524a3b3e41f8906bafd483fb6fc1e0a14b09bfbf76ee16c7d2fa77",
  "virtLauncher": "sha256:56fb378b3d0b16daa1f2202f8ff0da4e6236d79827994e4ad6e7cf4d002c64fd",
  "virtOperator": "sha256:42bbd431fed5e00b18af6b83a742f9e7f86c64d13fa690edec48cc982422c7b1",
  "virtualizationApi": "sha256:80a872c96aa377605622a3ce09ec3bae8961d916f86179b68d56681edfced4e1",
  "virtualizationController": "sha256:da1eba637345d71602f84d83fe2306f053568462f16a72dadb51cdfc9415878f",
  "vmRouteForge": "sha256:261fe34e18debc540ef1748d3aabeffcca8bc8b398cefffe673690d6ce8a3e92"
}

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@fl64 fl64 marked this pull request as draft September 17, 2024 13:41
@fl64 fl64 force-pushed the chore/module/remove-builders-and-artifacts-from-module-images branch from b14e0ba to 7db0caa Compare September 17, 2024 13:44
@fl64 fl64 changed the title chore(module): remove builders and artifacts from module images chore(module): remove builders and artifacts from images_digests.json Sep 17, 2024
@fl64 fl64 force-pushed the chore/module/remove-builders-and-artifacts-from-module-images branch from 7db0caa to fcd2144 Compare September 17, 2024 14:04
@fl64 fl64 requested a review from diafour September 17, 2024 14:19
@fl64 fl64 marked this pull request as ready for review September 17, 2024 14:19
@fl64 fl64 force-pushed the chore/module/remove-builders-and-artifacts-from-module-images branch 5 times, most recently from 40636fa to 845663d Compare September 18, 2024 05:52
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
@fl64 fl64 force-pushed the chore/module/remove-builders-and-artifacts-from-module-images branch from 845663d to 19fcb29 Compare September 18, 2024 06:19
@fl64 fl64 merged commit a2a0254 into main Sep 18, 2024
19 checks passed
@fl64 fl64 deleted the chore/module/remove-builders-and-artifacts-from-module-images branch September 18, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants