refactor(cdi): update to v1.60.3 #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
commented
Sep 17, 2024
images/cdi-artifact/patches/012-add-caps-for-deckhouse-provisioners.patch
Show resolved
Hide resolved
diafour
force-pushed
the
refactor/cdi/update-to-1-60
branch
2 times, most recently
from
bb6b134
to
5b391eb
Compare
diafour
force-pushed
the
refactor/kubevirt/update-to-1.3.1
branch
2 times, most recently
from
14e4380
to
a320fd9
Compare
An error occurred while trying to automatically change base from
refactor/kubevirt/update-to-1.3.1
to
main
September 26, 2024 14:34
diafour
force-pushed
the
refactor/cdi/update-to-1-60
branch
from
f3dd568
to
1ee4176
Compare
universal-itengineer
added
the
build/self-hosted/virt-runners
diafour
force-pushed
the
refactor/cdi/update-to-1-60
branch
from
2babe02
to
420f8ee
Compare
universal-itengineer
added
build/self-hosted/virt-runners
universal-itengineer
force-pushed
the
refactor/cdi/update-to-1-60
branch
2 times, most recently
from
90fabbb
to
fb8c51d
Compare
universal-itengineer
added
build/self-hosted/virt-runners
diafour
force-pushed
the
refactor/cdi/update-to-1-60
branch
from
fb8c51d
to
e5a9f39
Compare
- Use golang 1.22.7 - Build CDI components without bazel. - Remove 000-bundle-images.patch: not needed anymore. - Remove 006-customizer.patch: it is already in the upstream. - Optimize 011-change-storage-class-for-scratch-pvc.patch: one line change is required. - Optimize 013-converting-images-on-filesystem-to-qcow2.patch: move new code in a separate file to increase chances to apply without problems in the future. - Fix evanphx/json-patch/v5 'replace' operation behaviour. - Remove redundant imports reformats in patches, remove changes in BUILD.bazel files. - Update base image to alt:p11, remove glibc updating. - Shrink cdi images by removing more apt caches. - Rename dvcr binaries, change _ to -. - Use cdi libraries 1.60.3 in virtualization-controller. - Add more rules for kube-api-rewriter. --- Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com> Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
diafour
force-pushed
the
refactor/cdi/update-to-1-60
branch
from
e5a9f39
to
ecb7a8f
Compare
…troller CDI always requests scratch space with a Filesystem volume mode, regardless of the volume mode of the related DataVolume. An additional overhead space should be reserved for the Filesystem volume. By default, this overhead is taken from the CDI Config and is not dynamically updated based on the target PVC size. As a result, the target PVC size with the overhead from the CDI Config may be insufficient to successfully complete PVC creation. To address this, since there is no strict formula for ext4 filesystem overhead, empirical estimates of the filesystem overhead were provided based on the target PVC size: - return 0 for target PVC size == 0 - add 40% for target PVC size < 24Mi - add 25% for target PVC size < 512Mi - add 15% for target PVC size < 4096Mi - add 10% for target PVC size >= 4096Mi Previously, this overhead was added at the level of our controller, which led to an undesirable increase in the size of images and disks. As part of this PR, the addition of an overhead is now taking place at the cdi controller level. --------- Signed-off-by: Isteb4k <dmitry.rakitin@flant.com> Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
universal-itengineer
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
What is the expected result?
VirtualDisks work as previously.
Checklist