feat(vmclass): freeze features after first discovery

images/virtualization-artifact/pkg/controller/vmclass/internal/discovery.go

@@ -58,15 +58,15 @@ func (h *DiscoveryHandler) Handle(ctx context.Context, s state.VirtualMachineCla
 	}
 
 	cpuType := current.Spec.CPU.Type
-	//nolint:staticcheck
-	mgr := conditions.NewManager(changed.Status.Conditions)
+
 	if cpuType == virtv2.CPUTypeHostPassthrough || cpuType == virtv2.CPUTypeHost {
-		mgr.Update(conditions.NewConditionBuilder(vmclasscondition.TypeDiscovered).
+		cb := conditions.NewConditionBuilder(vmclasscondition.TypeDiscovered).
 			Generation(current.GetGeneration()).
 			Message(fmt.Sprintf("Discovery not needed for cpu.type %q", cpuType)).
 			Reason(vmclasscondition.ReasonDiscoverySkip).
-			Status(metav1.ConditionFalse).Condition())
-		changed.Status.Conditions = mgr.Generate()
+			Status(metav1.ConditionFalse)
+
+		conditions.SetCondition(cb, &changed.Status.Conditions)
 		return reconcile.Result{}, nil
 	}
 
@@ -79,16 +79,19 @@ func (h *DiscoveryHandler) Handle(ctx context.Context, s state.VirtualMachineCla
 		availableNodes[i] = n.GetName()
 	}
 
-	var featuresEnabled []string
+	var (
+		featuresEnabled    []string
+		featuresNotEnabled []string
+	)
 	switch cpuType {
 	case virtv2.CPUTypeDiscovery:
+		if changed.Status.Phase == virtv2.ClassPhaseReady {
+			featuresEnabled = changed.Status.CpuFeatures.Enabled
+			break
+		}
 		featuresEnabled = h.discoveryCommonFeatures(nodes)
 	case virtv2.CPUTypeFeatures:
 		featuresEnabled = current.Spec.CPU.Features
-	}
-
-	var featuresNotEnabled []string
-	if cpuType == virtv2.CPUTypeDiscovery || cpuType == virtv2.CPUTypeFeatures {
 		selectedNodes, err := s.NodesByVMNodeSelector(ctx)
 		if err != nil {
 			return reconcile.Result{}, err
@@ -116,13 +119,12 @@ func (h *DiscoveryHandler) Handle(ctx context.Context, s state.VirtualMachineCla
 			Status(metav1.ConditionFalse)
 	}
 
-	mgr.Update(cb.Condition())
+	conditions.SetCondition(cb, &changed.Status.Conditions)
 
 	sort.Strings(availableNodes)
 	sort.Strings(featuresEnabled)
 	sort.Strings(featuresNotEnabled)
 
-	changed.Status.Conditions = mgr.Generate()
 	changed.Status.AvailableNodes = availableNodes
 	changed.Status.CpuFeatures = virtv2.CpuFeatures{
 		Enabled:          featuresEnabled,

images/virtualization-artifact/pkg/controller/vmclass/internal/lifecycle.go

@@ -57,8 +57,6 @@ func (h *LifeCycleHandler) Handle(_ context.Context, s state.VirtualMachineClass
 		return reconcile.Result{Requeue: true}, nil
 	}
 
-	//nolint:staticcheck
-	mgr := conditions.NewManager(changed.Status.Conditions)
 	cb := conditions.NewConditionBuilder(vmclasscondition.TypeReady).
 		Generation(current.GetGeneration())
 	var phase virtv2.VirtualMachineClassPhase
@@ -103,9 +101,7 @@ func (h *LifeCycleHandler) Handle(_ context.Context, s state.VirtualMachineClass
 			Reason(vmclasscondition.ReasonSuitableNodesFound).
 			Status(metav1.ConditionTrue)
 	}
-
-	mgr.Update(cb.Condition())
-	changed.Status.Conditions = mgr.Generate()
+	conditions.SetCondition(cb, &changed.Status.Conditions)
 	changed.Status.Phase = phase
 
 	return reconcile.Result{}, nil

images/virtualization-artifact/pkg/controller/vmclass/internal/util.go

@@ -22,24 +22,24 @@ import (
 	"github.com/deckhouse/virtualization-controller/pkg/controller/conditions"
 	virtv2 "github.com/deckhouse/virtualization/api/core/v1alpha2"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2/vmclasscondition"
+	"github.com/deckhouse/virtualization/api/core/v1alpha2/vmcondition"
 )
 
 func isDeletion(class *virtv2.VirtualMachineClass) bool {
 	return class == nil || !class.GetDeletionTimestamp().IsZero()
 }
 
-func addAllUnknown(class *virtv2.VirtualMachineClass, conds ...vmclasscondition.Type) (update bool) {
-	//nolint:staticcheck
-	mgr := conditions.NewManager(class.Status.Conditions)
-	for _, c := range conds {
-		if add := mgr.Add(conditions.NewConditionBuilder(c).
-			Generation(class.GetGeneration()).
-			Reason(vmclasscondition.ReasonUnknown).
-			Status(metav1.ConditionUnknown).
-			Condition()); add {
-			update = true
+func addAllUnknown(vm *virtv2.VirtualMachineClass, conds ...vmclasscondition.Type) (update bool) {
+	for _, cond := range conds {
+		if conditions.HasCondition(cond, vm.Status.Conditions) {
+			continue
 		}
+		cb := conditions.NewConditionBuilder(cond).
+			Generation(vm.GetGeneration()).
+			Reason(vmcondition.ReasonUnknown).
+			Status(metav1.ConditionUnknown)
+		conditions.SetCondition(cb, &vm.Status.Conditions)
+		update = true
 	}
-	class.Status.Conditions = mgr.Generate()
 	return
 }