refactor(vmi-router): Use IP from our VirtualMachine #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use status.ipaddress instead of extracting ip from huge status in Kubevirt VM. - Proper use of controller-runtime - Drop kubevirt.io/client - Update netlink, cilium, controller-runtime, k8 dependencies. - Add aliases for netlink methods to develop with comfort in non-linux OSes. - Add golang 21 base image. Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
diafour
force-pushed
the
refactor/vmi-router-use-ip-from-dvp-vm
branch
from
134e718
to
7fcd9dd
Compare
fl64
approved these changes
Apr 26, 2024
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
We dont'want to use kube-proxy with this component. Also, dependency hell was a tech debt.
What is the expected result?
Checklist