Start on 65430 #48
Merged
Start on 65430 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngheloAlf
reviewed
Jul 20, 2024
Comment on lines
+237
to
+248
| switch (osTvType) { | ||
| case OS_TV_TYPE_PAL: | ||
| osViSetMode(&osViModeTable[16]); | ||
| break; | ||
|
|
||
| case OS_TV_TYPE_NTSC: | ||
| osViSetMode(&osViModeTable[2]); | ||
| break; | ||
|
|
||
| case OS_TV_TYPE_MPAL: | ||
| osViSetMode(&osViModeTable[30]); | ||
| break; |
There was a problem hiding this comment.
I think those indices should be OS_VI_PAL_LAN1, OS_VI_NTSC_LAN1 and OS_VI_MPAL_LAN1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits 65430 into a C file. Based on the rodata I don't think this file can actually be split anymore and may possibly have been called utility.c, but still needs some more investigation.