blockchain: Faster chain view block locator. #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Jul 9, 2018
davecgh
force-pushed
the
blockchain_chainview_blocklocator
branch
2 times, most recently
from
25760b2
to
761d0c6
Compare
davecgh
force-pushed
the
blockchain_chainview_blocklocator
branch
from
761d0c6
to
a5122d0
Compare
dajohi
reviewed
Jul 11, 2018
blockchain/chainview.go
Outdated
|
|
||
| // BlockLocator returns a block locator for the passed block node. The passed | ||
| // node can be nil in which case the block locator for the current tip | ||
| // associated with the view will be returned. This only differs from the |
There was a problem hiding this comment.
This /is/ the exported version :)
There was a problem hiding this comment.
Nice catch. Copy pasta strikes! Fixed.
davecgh
force-pushed
the
blockchain_chainview_blocklocator
branch
2 times, most recently
from
26a8f54
to
4c30593
Compare
jrick
approved these changes
Jul 20, 2018
This exposes the ability to more efficiently create a block locator from a chain view for a given block node by using their ability to do O(1) lookups. It also adds tests to ensure the behavior is correct.
davecgh
force-pushed
the
blockchain_chainview_blocklocator
branch
from
4c30593
to
6254fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #1337.
This exposes the ability to more efficiently create a block locator from a chain view for a given block node by using their ability to do O(1) lookups.
It also adds tests to ensure the behavior is correct.