blockchain: Add negative tests for forced reorg. #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Jul 9, 2018
This adds tests which ensure invalid blocks are rejected when attempting to force a reorganization to them. It also creates the invalid blocks in such a way that some of them have block index entries while others do not to ensure both scenarios are handled correctly.
davecgh
force-pushed
the
blockchain_blockindex_negative_tests
branch
from
89ba493
to
eec4f96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests which ensure invalid blocks are rejected when attempting to force a reorganization to them.
It also creates the invalid blocks in such a way that some of them have block index entries while others do not to ensure both scenarios are handled correctly.