blockchain: Make block index flushable. #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_flushable_blockindex
branch
2 times, most recently
from
68c6458
to
18b7c1a
Compare
alexlyp
approved these changes
Jul 26, 2018
jrick
approved these changes
Jul 26, 2018
This modifies the block index to support tracking modified nodes and flushing them to the database. This ensures that validation states set on arbitrary nodes are persisted to the database and helps pave the way towards supporting decoupling the chain processing logic from the download logic. In the immediate term, as of this commit, side chains which encounter an invalid block will no longer potentially have to be revalidated to discover they are invalid after restart. A few comments are also improved while here.
davecgh
force-pushed
the
blockchain_flushable_blockindex
branch
from
18b7c1a
to
b968b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #1367.
This modifies the block index to support tracking modified nodes and flushing them to the database. This ensures that validation states set on arbitrary nodes are persisted to the database and helps pave the way towards supporting decoupling the chain processing logic from the download logic.
In the immediate term, as of this commit, side chains which encounter an invalid block will no longer potentially have to be revalidated to discover they are invalid after restart.
A few comments are also improved while here.
This is work towards #1145.