multi: update database error types. #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
update_db_error_types
branch
from
ebe1cf9
to
7329c9b
Compare
dnldd
force-pushed
the
update_db_error_types
branch
3 times, most recently
from
ef83ecd
to
07bdc21
Compare
dnldd
force-pushed
the
update_db_error_types
branch
from
07bdc21
to
7e6f595
Compare
dnldd
force-pushed
the
update_db_error_types
branch
2 times, most recently
from
cd8af71
to
4575b7d
Compare
davecgh
requested changes
Dec 18, 2020
This updates the database error types to leverage go 1.13 errors.Is/As functionality as well as confirm to the error infrastructure best practices.
dnldd
force-pushed
the
update_db_error_types
branch
from
4575b7d
to
30e566f
Compare
davecgh
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the database error types to leverage go 1.13 errors.Is/As functionality as well as confirm to the error infrastructure best practices outlined in #2181.