Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain/stake: update error types. #2264

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Jul 15, 2020

This updates the stake error types to leverage go 1.13 errors.Is/As functionality as well as confirm to the error infrastructure best practices outlined in #2181.

@davecgh davecgh added this to the 1.7.0 milestone Jul 15, 2020
@dnldd dnldd force-pushed the update_stake_error_types branch 6 times, most recently from a1f4241 to 64c7a88 Compare July 19, 2020 23:40
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the tests, error messages, and error handling more consistent with the rest of the code! It's something I've noticed for a while, but never had time to spend on.

blockchain/stake/error_test.go Show resolved Hide resolved
blockchain/stake/error_test.go Outdated Show resolved Hide resolved
blockchain/stake/error_test.go Outdated Show resolved Hide resolved
This updates the stake error types to leverage go
1.13 errors.Is/As functionality as well as confirm
to the error infrastructure best practices.
@davecgh davecgh merged commit 2646485 into decred:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants