Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ticketdb: update error types. #2279

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Jul 20, 2020

This updates the ticketdb error types to leverage go 1.13 errors.Is/As functionality as well as conform to the error infrastructure best practices outlined in #2181.

@dnldd dnldd force-pushed the update_ticketdb_error_types branch from 3203185 to 1564aed Compare July 20, 2020 14:25
@davecgh davecgh added this to the 1.7.0 milestone Jul 20, 2020
@dnldd dnldd force-pushed the update_ticketdb_error_types branch from 1564aed to febf54a Compare October 21, 2020 11:28
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting all these updated. I just spotted a couple of small things in the tests to get updated and then this can be merged.

blockchain/stake/internal/ticketdb/error_test.go Outdated Show resolved Hide resolved
blockchain/stake/internal/ticketdb/error_test.go Outdated Show resolved Hide resolved
@dnldd dnldd force-pushed the update_ticketdb_error_types branch from febf54a to 220da56 Compare December 15, 2020 21:56
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after rebase.

This updates the ticketdb error types to leverage
go 1.13 errors.Is/As functionality as well as
conform to the error infrastructure best practices.
@dnldd dnldd force-pushed the update_ticketdb_error_types branch from 220da56 to 051901c Compare December 16, 2020 22:41
@davecgh davecgh merged commit e4e085c into decred:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants