Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: update blockchain/standalone error types. #2280

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Jul 20, 2020

This updates the standalone error types to leverage go 1.13 errors.Is/As functionality as well as conform to the error infrastructure best practices outlined in #2181.

@davecgh davecgh added this to the 1.7.0 milestone Jul 20, 2020
@dnldd dnldd force-pushed the update_standalone_error_types branch from 2c1c497 to 5d529d7 Compare September 28, 2020 01:18
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Looks good overall I only spotted one typo and some test error handling that can be simplified due to the changes.

blockchain/standalone/error_test.go Outdated Show resolved Hide resolved
blockchain/standalone/pow_test.go Outdated Show resolved Hide resolved
blockchain/standalone/pow_test.go Outdated Show resolved Hide resolved
blockchain/standalone/treasury_test.go Outdated Show resolved Hide resolved
blockchain/standalone/treasury_test.go Outdated Show resolved Hide resolved
@davecgh davecgh modified the milestones: 1.7.0, 1.6.0 Sep 28, 2020
This updates the standalone error types to leverage go
1.13 errors.Is/As functionality as well as conform
to the error infrastructure best practices.
@dnldd dnldd force-pushed the update_standalone_error_types branch from 5d529d7 to 7c95fd9 Compare September 28, 2020 02:27
@davecgh davecgh merged commit acedac5 into decred:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants