multi: Introduce database v3 #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares the dependent modules for a version bump of the database module by pointing their required version to the most recent one and removing replace directives where they exist.
This bumps the major version of the database module to v3. This is needed because the current code already has backwards incompatible changes.
|
Just noticed #2653 was already opened and closed (unmerged). To make it more explicit, the specific change that prompted me to send this was introduced by #2261, which changed the exported Dcrwallet already updated to the newest (master) version of the database/v2 module, so this now breaks projecs which use both dcrwallet and database/v2 (through transitive deps) but haven't been updated to use the new error structure in database (e.g. rpcclient/v6). I hadn't noticed the previous PR, otherwise I would have asked first whether to open this or re-open the old one. |
davecgh
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new major version for the
github.com/decred/dcrd/databasemodule, namely v3.The current code on master already has breaking changes compared to the last released version of the database module (v2.0.2) (for example, the
Errorstructure switched theErrorCodemember forErr). Therefore, a new major version bump is required before releasing the next version of this module.The first commit "locks" local users of the database module to the last available development version of the module (the one in the current tip of the master branch) and removes replace directives, so that the next commit can perform the version bump of the database module without requiring changes in client code.
A future PR will switch all client code to database/v3. This needs to be done separately (instead of on a single PR) because otherwise
go mod downloadwill fail and CI tests won't pass (due to the first database/v3 commit not yet being present in a branch of the dcrd repository).