Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mixing: Introduce module. #3207
mixing: Introduce module. #3207
Changes from all commits
2bb4583
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is unfortunately rife with panic footguns like this (e.g. all of the panics when slice lengths don't match Msize and the like). Since this is a development module, we can allow it for now, but I'd really like to see all of these methods that can fail with trivially incorrect input updated to return proper errors instead of instead of being so brittle with panics everywhere. The panics with incorrectly sized slices could all be avoided by just taking concrete arrays of the proper size.
This is the type of code that exported dcrd code everywhere else tries to avoid because small things that should just be normal errors like off by one bugs can bring down an entire process.