Bug Fixes and Enhancements #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2017
This was referenced Sep 8, 2017
Closed
|
ACK I have tested this and updated the related issues. Can be merged following code review. |
gozart1
reviewed
Sep 8, 2017
views/root.tmpl
Outdated
| @@ -356,7 +356,7 @@ | |||
| </table> | |||
| </div> | |||
| <div class="col-md-6 text-left"> | |||
| <div>Number of Tickets Mined in Last Block: <strong id="feeinfo_number">{{.StakeSummary.Feeinfo.Number}}</strong></div> | |||
| <div>Tickets in Lastest Block: <strong id="feeinfo_number">{{.StakeSummary.Feeinfo.Number}}</strong></div> | |||
chappjc
approved these changes
Sep 8, 2017
views/tx.tmpl
Outdated
| <td>{{.Sequence}}</td> | ||
| <td>{{.Tree}}</td> | ||
| <td>{{.AmountIn | getAmount}}</td> | ||
| <td>{{if eq .AmountIn -1e-8}} N/A {{else}} {{.AmountIn}} {{end}}</td> |
There was a problem hiding this comment.
Unless we understand clearly where -1e-8 is coming from (is it hard-coded somewhere?) I'd prefer if we change this to <0, but it's OK for now.
web.go
Outdated
| }) | ||
| if err != nil { | ||
| http.Error(w, "template execute failure", http.StatusInternalServerError) | ||
| return |
|
The "dcrdata.org" link in the footer goes to the wrong place. I'm not sure where it should go tbh as we don't have an general organization page, and only a basic GH page for the dcrdata repository at http://www.dcrdata.org/ |
oluwandabira
force-pushed
the
tx-errors
branch
from
c27c544
to
6b27441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address issues:
#116, #117, #118, #119, #120, #122, #123, #124 and #126