-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pool: update error types. #245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
update_error_types
branch
from
September 9, 2020 15:05
0312026
to
6d85d49
Compare
This updates error types to leverage go 1.13 errors.Is/As functionality.
This updates errors generated by the accepted work type to use defined error types and provide more error context.
This updates errors generated by the account type to use defined error types and provide more error context.
This updates errors generated by the job type to use defined error types and provide more error context.
This updates errors generated by the payment type to use defined error types and provide more error context.
This updates errors generated by the share type to use defined error types and provide more error context.
This updates errors generated by database helper funcs to use defined error types and provide more error context.
This updates errors generated by message helpers to use defined error types and provide more error context.
This updates errors generated by the difficulty type to use defined error types and provide more error context.
This updates errors and logs generated by the chainstate type to use defined error types and provide more error context.
This updates errors generated by the payment manager type to use defined error types and provide more error context.
This updates errors generated by the db upgrade helpers to use defined error types and provide more error context.
This updates errors and log generated by the client type to use defined error types and provide more error context.
This updates errors and logs generated by the hub type to use defined error types and provide more error context.
dnldd
force-pushed
the
update_error_types
branch
from
September 11, 2020 01:35
6d85d49
to
651e8f2
Compare
jholdstock
requested changes
Sep 14, 2020
I also updated all |
dnldd
force-pushed
the
update_error_types
branch
from
September 14, 2020 22:35
4ab64d1
to
096c2a1
Compare
jholdstock
reviewed
Sep 15, 2020
jholdstock
reviewed
Sep 15, 2020
Removed |
jholdstock
reviewed
Sep 16, 2020
jholdstock
requested changes
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more issues spotted and then this looks good to go
jholdstock
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the error types to leverage go 1.13 errors.Is/As functionality, conforming to the updated error infrastructure detailed here.