vsp: Introduce VSPTicket struct.

All of the fields necessary to register a ticket with a VSP are set upon
creation of a VSPTicket struct. This helps to ensure no invalid tickets
are ever added to a VSP client, and removes a lot of duplicated logic
from feePayment.

internal/rpc/jsonrpc/methods.go

@@ -3491,7 +3491,17 @@ func (s *Server) processUnmanagedTicket(ctx context.Context, icmd interface{}) (
 		return nil, err
 	}
 
-	err = vspClient.Process(ctx, ticketHash, nil)
+	w, ok := s.walletLoader.LoadedWallet()
+	if !ok {
+		return nil, errUnloadedWallet
+	}
+
+	ticket, err := w.NewVSPTicket(ctx, ticketHash)
+	if err != nil {
+		return nil, err
+	}
+
+	err = vspClient.Process(ctx, ticket, nil)
 	if err != nil {
 		return nil, err
 	}
@@ -4671,7 +4681,13 @@ func (s *Server) updateVSPVoteChoices(ctx context.Context, w *wallet.Wallet, tic
 		if err != nil {
 			return err
 		}
-		err = vspClient.SetVoteChoice(ctx, ticketHash, choices, tspendPolicy, treasuryPolicy)
+
+		ticket, err := w.NewVSPTicket(ctx, ticketHash)
+		if err != nil {
+			return err
+		}
+
+		err = vspClient.SetVoteChoice(ctx, ticket, choices, tspendPolicy, treasuryPolicy)
 		return err
 	}
 
@@ -4688,9 +4704,15 @@ func (s *Server) updateVSPVoteChoices(ctx context.Context, w *wallet.Wallet, tic
 		if err != nil {
 			return err
 		}
+
+		ticket, err := w.NewVSPTicket(ctx, hash)
+		if err != nil {
+			return err
+		}
+
 		// Never return errors here, so all tickets are tried.
 		// The first error will be returned to the user.
-		err = vspClient.SetVoteChoice(ctx, hash, choices, tspendPolicy, treasuryPolicy)
+		err = vspClient.SetVoteChoice(ctx, ticket, choices, tspendPolicy, treasuryPolicy)
 		if err != nil {
 			return err
 		}

internal/rpc/rpcserver/server.go

@@ -4161,14 +4161,21 @@ func (s *walletServer) SyncVSPFailedTickets(ctx context.Context, req *pb.SyncVSP
 		return nil, status.Errorf(codes.Unknown, "TicketBuyerV3 instance failed to start. Error: %v", err)
 	}
 
-	// process tickets fee if needed.
+	// Process tickets fee if needed.
 	for _, ticketHash := range failedTicketsFee {
+
+		// If it fails to process again, we log it and continue with
+		// the wallet start.
+		// Not sure we need to log here since it's already warned elsewhere
+
+		t, err := s.wallet.NewVSPTicket(ctx, &ticketHash)
+		if err != nil {
+			continue
+		}
 		feeTx := new(wire.MsgTx)
-		err := vspClient.Process(ctx, &ticketHash, feeTx)
+		err = vspClient.Process(ctx, t, feeTx)
 		if err != nil {
-			// if it fails to process again, we log it and continue with
-			// the wallet start.
-			// Not sure we need to log here since it's already warned elsewhere
+			continue
 		}
 	}
 	return &pb.SyncVSPTicketsResponse{}, nil
@@ -4325,7 +4332,11 @@ func (s *walletServer) SetVspdVoteChoices(ctx context.Context, req *pb.SetVspdVo
 			return err
 		}
 		if ticketHost == vspHost {
-			err = vspClient.SetVoteChoice(ctx, hash, choices, tSpendChoices, treasuryChoices)
+			ticket, err := s.wallet.NewVSPTicket(ctx, hash)
+			if err != nil {
+				return err
+			}
+			err = vspClient.SetVoteChoice(ctx, ticket, choices, tSpendChoices, treasuryChoices)
 			if err != nil {
 				return err
 			}