-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: verifyseed rpc #1158
base: master
Are you sure you want to change the base?
multi: verifyseed rpc #1158
Conversation
735af84
to
08f0f70
Compare
f0a4f28
to
a4c45de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was only able to review the diff, not test the implementation, because this doesn't even compile.
a6c8b98
to
6819a23
Compare
@marcopeereboom should of put a [WIP] but didn't want anyone to relook at this til completed. |
0a8b6d1
to
2b2ea48
Compare
b1a0739
to
ce931c9
Compare
6e765d7
to
3cd4322
Compare
0cb1449
to
5f79bc1
Compare
ca1d853
to
6fe3255
Compare
314ee95
to
ea63432
Compare
ea63432
to
c578985
Compare
A function deriveCoinTypeKey is created within methods.go that is used in another a new method of the jsonrpc serve VerifySeed. All necessary changes to autogenerate the help for this rpc call are included as well.
Main purpose of this is to quickly test wallet builds that require seeds that are external to the wallet's db
A use case for this is testing verifyseed rpc. Currently rpctest harness' memwallet does not allow for its seed to be changed.
This pull request doesn't pass the build tests, has committed merge conflicts in a file only you have touched, commits a 4M executable, and you want me to review this? |
This is for #1037 (linking for discoverability). |
@jrick thought I had pushed changes. I'll ping you when its here and double checked as ready. thanks |
Sorry about the PR close on the last guy, old ghost branch not appearing on my machine or remotely. Fixed what was needed.