multi: add listtickets json rpc command #1169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kLkA
force-pushed
the
add_listalltickets_rpc_method
branch
8 times, most recently
from
324fb19
to
76651ee
Compare
jrick
requested changes
Jul 3, 2018
rpc/legacyrpc/methods.go
Outdated
| if connected { | ||
| chainClient, err = chain.RPCClientFromBackend(n) | ||
| if err != nil { | ||
| err := chainClient.Ping() |
There was a problem hiding this comment.
this will panic dereferencing a nil pointer
kLkA
force-pushed
the
add_listalltickets_rpc_method
branch
2 times, most recently
from
f57a098
to
ab1a1f6
Compare
|
@jrick I'm ready to hear for you notions after SPV is ready, to pass CI decred/dcrd#1267 changes have to be deployed on dcrd project |
kLkA
force-pushed
the
add_listalltickets_rpc_method
branch
2 times, most recently
from
44e6e56
to
f273423
Compare
listtickets return detailed info about ticket details, spender and status.
kLkA
force-pushed
the
add_listalltickets_rpc_method
branch
from
f273423
to
5fb3f09
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listtickets cmd return detailed info about ticket details, spender
and state
#1168