spv: Fetch cfilters from multiple remote peers #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the initial cfilter fetching stage to use multiple peers and to keep trying to fetch the cfilters even when the peer from which headers were received disconnects.
This commits adds a watchdog timer to the initial cfilter fetching, triggered when a batch takes too long to be successfully fetched. In some situations, specially close to the tip, the sidechain forest may be populated with one (or more) headers for which no cfilter is available in the network. In this situation, the syncer could end up in a state where it does not advance due to waiting for cfilters that will never be sent by any peers. To alleviate this issue, a watchdog timer is started for every batch of cfilters. If that timer is triggered, then the entire sidechain forest is pruned, ensuring the next batch of headers that will be fetched will be using fresh block locators and that the best chain selected for fetching cfilters will be for these fresh headers. The timer interval is set for 2 minutes, which given the stall timer of 30 seconds per peer means at least 4 peers will be searched for the cfilters, before giving up and resetting the forest.
|
the watchdog commit looks like a prime candidate for unfortunately, that would require go 1.21 as a minimum, so we can't use that yet. |
jrick
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the cfilter fetching stage of the initial sync process to request cfilters from multiple peers instead of a single one.
This spreads the load across multiple peers, making the initial sync process (on average) slightly faster due to lower remote peer resource usage.