Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: Allow coin type upgrades on simnet #2328

Merged
merged 1 commit into from
Feb 7, 2024

Commits on Feb 7, 2024

  1. wallet: Allow coin type upgrades on simnet

    This removes the enforced coin type upgrade for simnet wallets, in order
    to allow testing the upgrade code path under simnet.
    
    Prior to this commit, the coin type of a restored simnet wallet was
    always upgraded to the corresponding SLIP0044 coin type, in order to
    ensure that the address meant to be used as the mining address for the
    dcrd node was never made invalid. However, despite this enforced
    upgrade, there is still a bug with account and address discovery if the
    wallet was started before at least blocks 1 and 2 were mined in the
    underlying full node.
    
    To alert simnet users about this bug this commit adds a note displayed
    during simnet wallet creation.
    
    In the future, this bug may be fully fixed by ensuring the underlying
    node is fully synced and has blocks before the sync process completes.
    This will need to take into account use cases where the underlying node
    is meant to be fully unsynced (such as air-gapped wallets).
    matheusd committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    bbb072e View commit details
    Browse the repository at this point in the history