-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there any reason why the constructor function doesn't normalize its inputs? #102
Comments
can you give an example? there's probably a very good reason — if not simply for the sake of speed, and that doing this via Ender would do it anyway. |
@ded I was discussing this with @adlwalrus and I couldn't come with a good reason that
The manip methods are clever enough to That, and the fact that |
hmmm.... i suppose so... we'd have to bump up the package a minor version tho |
and update a few tests... |
Anyone wanna do it? If not, then anyone wanna coach me through doing it? |
Well that was silly... how does this look? #103 (I had a look over the tests to see if there were any I could clearly identify as needing to be updated, but it appears not.) (Also, I'm still not sure what @rvagg was talking about with |
If it did, it would save a hell of a lot of
bonzo.create()
s.Anyway, it came up in IRC, and I was wondering if anyone else might be able to provide insight. If there's no good reason not to, then I'd like to propose that normalization get added...
Cheers!
The text was updated successfully, but these errors were encountered: