Adds query param when using route param with custom request class

[paulchill]

I have a route which accepts an id as a route param:

Route::get('process/{id}', [ProcessController::class, 'show']);

Used in my controller
public function show(ProcessRequest $request, string $id)

Using a custom Request class

use Illuminate\Foundation\Http\FormRequest;
class ProcessRequest extends FormRequest

Scramble, adds an an extra id as a query param which i can't seem to remove i use the standard request class

[romalytvynenko]

@paulchill can you share the entire source of your form request class?

[paulchill]

Sure!

<?php

namespace App\Http\Requests\Models;

use Illuminate\Foundation\Http\FormRequest;

class ProcessRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
            'id' => 'required|string'
        ];
    }

    /**
     * Get the error messages for the defined validation rules.
     *
     * @return array
     */
    public function messages()
    {
        return [
            'id.required' => 'The id field is required.',
            'id.string' => 'The id field must be a string.',
        ];
    }

    /**
     * Include route parameters in validation data.
     *
     * @return array
     */
    public function validationData()
    {
        return array_merge($this->request->all(), [
            'id' => $this->route('id'),
        ]);
    }
}

I tried adding in validationData() to see if it would help but no luck.

[romalytvynenko]

Oh, I see. Yeah, Scramble indeed "sees" it as a separate parameter as it is presented in the validation rules.

Will fix this

[paulchill]

Great thanks - was driving me nuts :)

[romalytvynenko]

@paulchill after more thoughts, I believe that this behavior is correct 🫣 At the same time, the stuff should not drive you nuts! So I'm about to allow to manually opt out of some parameters documentation by using @ignoreParam annotation.

So you'd need to write rules like so:

public function rules()
{
    return [
        /** @ignoreParam */
        'id' => 'required|string'
    ];
}

Does that make sense?

[paulchill]

I can't push it to production with the issue :(

 public function rules()
    {
        
        return [
            /** @ignoreParam */
            'id' => 'required|string'
        ];
    }

Doesn't effect it - after clearing cache too.

[romalytvynenko]

@paulchill yeah yeah, that was just the idea when I wrote the comment. Just released it. Please upgrade to v0.10.11

[paulchill]

Gent - thank you :)