Respect string type when parsing validation rules' examples #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements @Tryfciu 's code that fixes the problem mentioned here.
Now, when we have an
@example
doc specification with a numeric value, it treats this value according to the type specified for it right at the body request example. So, if this numeric value is astring
, it will have quotation marks and won't be parsed into a number.Here's a practical example:
Notice that
phone_number
andsome_value
both have numeric values but should be treated as strings because of the validation type.So instead of being parsed right into numbers, they will be actual strings:
This also fixes the fact that if we have a string like
"+1"
, it won't be parsed into just1
like before :)Now of course, if we specify that they are numbers, it treats them as so: