Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple requests #468 #473

Closed
wants to merge 2 commits into from
Closed

Multiple requests #468 #473

wants to merge 2 commits into from

Conversation

DarKsandr
Copy link

@DarKsandr
Copy link
Author

Снимок экрана от 2024-08-01 07-42-12
Снимок экрана от 2024-08-01 07-41-58

@romalytvynenko
Copy link
Member

@DarKsandr please add a test.

@DarKsandr
Copy link
Author

@romalytvynenko Is this enough? I'm not very good at testing

@DarKsandr
Copy link
Author

@romalytvynenko are there any problems with the task?

@romalytvynenko
Copy link
Member

@DarKsandr I'm still hesitant about the solution because the original issue may be solved once static analysis for rules are introduced. I'll return to this soon

@DarKsandr
Copy link
Author

@romalytvynenko unfortunately static analysis will not solve the problem of multiple requests unless you combine them into one

@romalytvynenko
Copy link
Member

@DarKsandr it will! With simple array_merge support, all the PHPDoc annotations will be analyzed.

@romalytvynenko
Copy link
Member

Closing in favor of future static analysis based solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants