Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

申请创建sig-Fedora #436

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

申请创建sig-Fedora #436

wants to merge 1 commit into from
+76 −0

Conversation

tekkamanninja
Copy link 

* add-sig

@deepin-ci-robot
Copy link
Contributor

Hi @tekkamanninja. Thanks for your PR. 😃

@deepin-ci-robot
Copy link
Contributor

Hi @tekkamanninja. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BLumia
BLumia requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外请问你们目前有加 dde-porting 小组或者在 dde-porting 小组的群里吗？你们的小组工作内容和 DDE 桌面环境的移植是强相关的，dde-porting 小组本身也会在必要的时候提供一些移植相关的注意事项，也会协助推进一些移植问题的解决。

（这个 request change 指的是下面列出的问题）

sig/Fedora/README.md Outdated
Comment on lines 27 to 32
* 本着开源为快乐的原则，我们欢迎所有对此目标感兴趣的爱好者加入。
* 不要求产出速度，不强调贡献排行，参与者尽力而为即可。
* 通过向[此项目](https://github.com/deepin-community/sig-Fedora/issues)提交issue，说明加入原因。通过后
* 对于向deepin贡献代码/软件包等章程请遵循其官方文档，这里不再赘述。

ps: 章程目前还不完善，有兴趣的同步可以加入讨论。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请按实际情况编写，不要照搬其它小组的章程。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我稍微改一下，马上

sig/Fedora/metadata.yml Outdated
Comment on lines 18 to 24
id:
- handle: U2FsdGVkX1
id:
- handle: hezhengyu
id:
- handle: milkice233
id:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要提供 id。提供方式在 metadata 模板中有注明。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的，谢谢，我正在叫他们发给我

@BLumia BLumia mentioned this pull request Sep 20, 2024
Open
BLumia
BLumia previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

正式开始 SIG 创建流程之前，我这边也确认下：

申请中提到的 sig-Fedora 这个仓库是确实需要的么？之前的 SIG 很多是申请了最终都没有在使用这么个仓库，sig-xxx 名字的仓库不是创建 SIG 的必要条件，所以你们可以按实际情况决定到底要不要创建，以及如果要的话，是否需要基于目前的模板仓库创建（答复下我就好，当然如果答案是不需要的话，得一并更新下这个PR里的对应描述）。

@tekkamanninja
Copy link
Author

正式开始 SIG 创建流程之前，我这边也确认下：

申请中提到的 sig-Fedora 这个仓库是确实需要的么？之前的 SIG 很多是申请了最终都没有在使用这么个仓库，sig-xxx 名字的仓库不是创建 SIG 的必要条件，所以你们可以按实际情况决定到底要不要创建，以及如果要的话，是否需要基于目前的模板仓库创建（答复下我就好，当然如果答案是不需要的话，得一并更新下这个PR里的对应描述）。

需要，是您帮忙开一个 sig-Fedora 仓库， 然后把现在的小组成员加入进去作为维护人，我已经安排创建仓库内容了， 您这里创建好了，我们可以push上去

wineee
wineee suggested changes Sep 20, 2024
View reviewed changes
sig/Fedora/README.md Outdated
## 活动范围与目标

目标：为Fedora操作系统适配和维护DDE，确保Fedora发行版上DDE的质量，并吸引贡献者一同参与其中。具体工作有同步上游项目补丁、重要漏洞修复、新功能开发、BUG修复等。重要版本更新时，评估该版本对项目的影响和性能影响等，参与上游社区的建设工作，协助解答其他爱好者在相关领域遇到的问题、贡献补丁，修复上游BUG等。
活动范围：deepin社区论坛、邮件列表、Telegram、matrix、Slack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要给出具体的链接

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的 ， 我这就去setup，并补充link

@BLumia BLumia dismissed their stale review September 21, 2024 05:02

参见 wineee 的 review

wineee
wineee suggested changes Sep 23, 2024
View reviewed changes
sig/Fedora/metadata.yml Outdated
name: Fedora
blog:
rss:
matrix:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看提供了 matrix 群，这里也填一下

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

sig/Fedora/README.md Outdated

加入方法：

1. 在Telegram 或 matrix 或者 Slack中预先沟通。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中文中的英文单词左右的空格统一一下，建议左右都有空格，如果有 Slack 要提供链接，没有要更新描述

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@topazus
Copy link

topazus commented Sep 23, 2024

@tekkamanninja Can I apply into the group? Fedora packager account: https://src.fedoraproject.org/user/topazus

@tekkamanninja
Copy link
Author

@tekkamanninja Can I apply into the group? Fedora packager account: https://src.fedoraproject.org/user/topazus

sure, Could you make a PR , add you as a member after this is merged ?

@topazus
Copy link

topazus commented Sep 23, 2024

sure, Could you make a PR , add you as a member after this is merged ?

Ok, I will.

@shiptux
Copy link

shiptux commented Sep 23, 2024

/approve

1 similar comment
@felixonmars
Copy link

/approve

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, felixonmars, justforlxz, RevySR, shiptux, wineee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BLumia BLumia BLumia approved these changes

@justforlxz justforlxz justforlxz approved these changes

@RevySR RevySR RevySR approved these changes

@wineee wineee wineee approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tekkamanninja @deepin-ci-robot @topazus @shiptux @felixonmars @BLumia @justforlxz @RevySR @wineee