fix(sql): fix queries where value legitimately begins with $ #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
There are legitimate cases where a value may begin with
$
, and the current reference implementation breaks those cases. Example case, I have a query that looks for duplicate products named$100 Gift Card
. This should result in:but it instead translates into:
This PR introduces a new
SqlReference
class that can be used for cases where a reference is actually desired.I only see a single usage case in the Deepkit source, and it's in the tests. It's unclear how many Deepkit users this may impact, but I do think it's important to fix.
Relinquishment of Rights
Please mark following checkbox to confirm that you relinquish all rights of your changes: