chore: fix hanging and erroring tests (#466)

- Use `127.0.0.1` instead of `localhost` to fix ipv4 vs ipv6 issues - Reduce traefik test flakiness - Fix grpcwebproxy download for arm64 - Get rid of `get-port` dependency for `nice-grpc`
deeplay-io · Oct 17, 2023 · 0d169ec · 0d169ec
1 parent 0509986
commit 0d169ec
Show file tree

Hide file tree

Showing 43 changed files with 250 additions and 391 deletions.
diff --git a/packages/nice-grpc-client-middleware-deadline/src/index.test.ts b/packages/nice-grpc-client-middleware-deadline/src/index.test.ts
@@ -1,4 +1,3 @@
-import defer = require('defer-promise');
 import {forever} from 'abort-controller-x';
 import {
   createChannel,
@@ -27,9 +26,9 @@ test('successful call', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(deadlineMiddleware)
     .create(TestService, channel);
@@ -57,9 +56,9 @@ test('absolute deadline', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(deadlineMiddleware)
     .create(TestService, channel);
@@ -89,9 +88,9 @@ test('relative deadline', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(deadlineMiddleware)
     .create(TestService, channel);

diff --git a/packages/nice-grpc-client-middleware-retry/src/index.test.ts b/packages/nice-grpc-client-middleware-retry/src/index.test.ts
@@ -31,9 +31,9 @@ test('basic', async () => {
     },
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(retryMiddleware)
     .create(TestDefinition, channel);
@@ -71,9 +71,9 @@ test('retries enabled', async () => {
     },
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(retryMiddleware)
     .create(TestDefinition, channel);
@@ -120,9 +120,9 @@ test('idempotent', async () => {
     },
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(retryMiddleware)
     .create(TestDefinition, channel);

diff --git a/packages/nice-grpc-error-details/src/index.test.ts b/packages/nice-grpc-error-details/src/index.test.ts
@@ -34,9 +34,9 @@ const beforeEachServerAndClientTest = async (
     },
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
 
   const rawClient = createClient(TestDefinition, channel);
 

diff --git a/packages/nice-grpc-opentelemetry/src/__tests__/bidiStreaming.ts b/packages/nice-grpc-opentelemetry/src/__tests__/bidiStreaming.ts
@@ -46,9 +46,9 @@ test('basic', async () => {
     },
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -120,7 +120,7 @@ test('basic', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 0,
         "rpc.grpc.status_text": "OK",
         "rpc.method": "TestBidiStream",
@@ -185,9 +185,9 @@ test('error', async () => {
     },
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -249,7 +249,7 @@ test('error', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 5,
         "rpc.grpc.status_text": "NOT_FOUND",
         "rpc.method": "TestBidiStream",
@@ -295,9 +295,9 @@ test('aborted iteration on client', async () => {
     },
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -365,7 +365,7 @@ test('aborted iteration on client', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 1,
         "rpc.grpc.status_text": "CANCELLED",
         "rpc.method": "TestBidiStream",

diff --git a/packages/nice-grpc-opentelemetry/src/__tests__/clientStreaming.ts b/packages/nice-grpc-opentelemetry/src/__tests__/clientStreaming.ts
@@ -46,9 +46,9 @@ test('basic', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -105,7 +105,7 @@ test('basic', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 0,
         "rpc.grpc.status_text": "OK",
         "rpc.method": "TestClientStream",
@@ -157,9 +157,9 @@ test('error', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -216,7 +216,7 @@ test('error', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 5,
         "rpc.grpc.status_text": "NOT_FOUND",
         "rpc.method": "TestClientStream",

diff --git a/packages/nice-grpc-opentelemetry/src/__tests__/context.ts b/packages/nice-grpc-opentelemetry/src/__tests__/context.ts
@@ -58,9 +58,9 @@ test('context propagation', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(async function* testClientMiddleware(call, options) {
       traceIdInClientMiddlewareStart = getCurrentTraceId();

diff --git a/packages/nice-grpc-opentelemetry/src/__tests__/serverStreaming.ts b/packages/nice-grpc-opentelemetry/src/__tests__/serverStreaming.ts
@@ -45,9 +45,9 @@ test('basic', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -100,7 +100,7 @@ test('basic', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 0,
         "rpc.grpc.status_text": "OK",
         "rpc.method": "TestServerStream",
@@ -150,9 +150,9 @@ test('error', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -202,7 +202,7 @@ test('error', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 5,
         "rpc.grpc.status_text": "NOT_FOUND",
         "rpc.method": "TestServerStream",
@@ -245,9 +245,9 @@ test('aborted iteration on client', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -296,7 +296,7 @@ test('aborted iteration on client', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 1,
         "rpc.grpc.status_text": "CANCELLED",
         "rpc.method": "TestServerStream",

diff --git a/packages/nice-grpc-opentelemetry/src/__tests__/unary.ts b/packages/nice-grpc-opentelemetry/src/__tests__/unary.ts
@@ -45,9 +45,9 @@ test('basic', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -84,7 +84,7 @@ test('basic', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 0,
         "rpc.grpc.status_text": "OK",
         "rpc.method": "TestUnary",
@@ -118,9 +118,9 @@ test('error', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -157,7 +157,7 @@ test('error', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 5,
         "rpc.grpc.status_text": "NOT_FOUND",
         "rpc.method": "TestUnary",
@@ -191,9 +191,9 @@ test('unknown error', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -235,7 +235,7 @@ test('unknown error', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 2,
         "rpc.grpc.status_text": "UNKNOWN",
         "rpc.method": "TestUnary",
@@ -281,9 +281,9 @@ test('cancel', async () => {
     testBidiStream: throwUnimplemented,
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(openTelemetryClientMiddleware())
     .create(TestDefinition, channel);
@@ -328,7 +328,7 @@ test('cancel', async () => {
   expect(dumpSpan(serverSpan)).toMatchInlineSnapshot(`
     {
       "attributes": {
-        "net.peer.ip": "::1",
+        "net.peer.ip": "127.0.0.1",
         "rpc.grpc.status_code": 1,
         "rpc.grpc.status_text": "CANCELLED",
         "rpc.method": "TestUnary",

diff --git a/packages/nice-grpc-prometheus/src/__tests__/bidiStreaming.ts b/packages/nice-grpc-prometheus/src/__tests__/bidiStreaming.ts
@@ -33,9 +33,9 @@ test('basic', async () => {
     },
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(prometheusClientMiddleware())
     .create(TestDefinition, channel);
@@ -138,9 +138,9 @@ test('error', async () => {
     },
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(prometheusClientMiddleware())
     .create(TestDefinition, channel);
@@ -247,9 +247,9 @@ test('aborted iteration on client', async () => {
     },
   });
 
-  const port = await server.listen('localhost:0');
+  const port = await server.listen('127.0.0.1:0');
 
-  const channel = createChannel(`localhost:${port}`);
+  const channel = createChannel(`127.0.0.1:${port}`);
   const client = createClientFactory()
     .use(prometheusClientMiddleware())
     .create(TestDefinition, channel);