Add middleware for logging requests/responses via the grpc-web-devtools #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry, I didn't have enough time and energy lately to review this, but I didn't forget about it! |
aikoven
reviewed
Sep 27, 2023
|
Thank you for you contribution @segfault16! Please address these comments 👆 |
…t16/nice-grpc into grpc-devtools-middleware
|
@aikoven Comments have been addressed and I've added some tests for ts-proto and grpc-js |
aikoven
reviewed
Oct 12, 2023
|
Thanks! I'm going to merge this and release shortly. |
|
Published 📦 Could not figure out how to correctly publish a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #27.
This is an initial version for the middleware.
I've copied the structure in ``nice-grpc-client-middleware-deadline` and added the logic used in my project.
Feedback and help welcome ;)