Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nice-grpc-error-details): add long to dependencies #460

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

chentsulin
Copy link
Contributor

The nice-grpc-error-details pacakge requires long to work: https://www.runpkg.com/?nice-grpc-error-details@0.2.1/lib/proto/google/protobuf/duration.js#5

Add long to peerDependencies, so pnpm can install it into a correct folder.

@aikoven
Copy link
Contributor

aikoven commented Oct 2, 2023

Thank you for your PR!

You are right that long is required. Shouldn't it go to normal dependencies though?

@chentsulin chentsulin changed the title fix(nice-grpc-error-details): add long to peerDependencies fix(nice-grpc-error-details): add long to dependencies Oct 2, 2023
@chentsulin
Copy link
Contributor Author

Ok, I moved it into dependencies.

@aikoven aikoven merged commit 0863e8b into deeplay-io:master Oct 2, 2023
@aikoven
Copy link
Contributor

aikoven commented Oct 2, 2023

Thanks! Will make a release shortly.

@aikoven
Copy link
Contributor

aikoven commented Oct 2, 2023

Published 📦 nice-grpc-error-details@0.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants