Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #33 #34

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Fix Issue #33 #34

merged 1 commit into from
Apr 27, 2024

Conversation

matthewdeanmartin
Copy link
Contributor

Warning goes away.

I did run the unit tests, on window I get this... but I didn't do anything with code related to that. I'm guessing it is not a cross platform unit test.

self = <encodings.cp1252.IncrementalDecoder object at 0x00000266205ECDD0>
input = b'Usage examples (command-line and programmatic use):\r\n\r\n- Standard one-line sparkline\r\nsparklines 3 1 4 1 5 9 2...6\x82\xe2\x96\x85 \xe2\x96\x85\xe2\x96\x82\xe2\x96\x88\xe2\x96\x84\xe2\x96\x81\xe2\x96\x84\xe2\x96\x81\xe2\x96\x83\r\n'
final = True

    def decode(self, input, final=False):
>       return codecs.charmap_decode(input,self.errors,decoding_table)[0]
E       UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 171: character maps to <undefined>

C:\Users\matth\AppData\Local\Programs\Python\Python311\Lib\encodings\cp1252.py:23: UnicodeDecodeError
================================================ short test summary info =================================================
FAILED tests/test_sparkline.py::test_demo_consistency - UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 171: character maps to <undefined>

@deeplook deeplook merged commit 04d01c5 into deeplook:main Apr 27, 2024
8 checks passed
@deeplook
Copy link
Owner

It's been released now as 0.5.0 and published on PyPI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants