Support for enum expression in default value parameters

deepmedia · Aug 24, 2024 · fdf3baf · fdf3baf
1 parent de57aa4
commit fdf3baf
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/knee-compiler-plugin/src/main/kotlin/utils/PoetUtils.kt b/knee-compiler-plugin/src/main/kotlin/utils/PoetUtils.kt
@@ -2,14 +2,18 @@ package io.deepmedia.tools.knee.plugin.compiler.utils
 
 import com.squareup.kotlinpoet.*
 import com.squareup.kotlinpoet.ParameterizedTypeName.Companion.parameterizedBy
+import io.deepmedia.tools.knee.plugin.compiler.codegen.CodegenType
 import org.jetbrains.kotlin.descriptors.*
 import org.jetbrains.kotlin.ir.declarations.*
 import org.jetbrains.kotlin.ir.expressions.IrConst
 import org.jetbrains.kotlin.ir.expressions.IrConstKind
 import org.jetbrains.kotlin.ir.expressions.IrExpressionBody
+import org.jetbrains.kotlin.ir.expressions.IrGetEnumValue
 import org.jetbrains.kotlin.ir.symbols.IrClassSymbol
+import org.jetbrains.kotlin.ir.symbols.IrEnumEntrySymbol
 import org.jetbrains.kotlin.ir.symbols.IrTypeParameterSymbol
 import org.jetbrains.kotlin.ir.types.*
+import org.jetbrains.kotlin.ir.util.dump
 import org.jetbrains.kotlin.types.Variance
 
 
@@ -212,8 +216,12 @@ fun IrValueParameter.defaultValueForCodegen(functionExpects: List<IrDeclarationW
             // is IrConstKind.Long -> CodeBlock.of(kind.valueOf(expression).toString() + "L")
             // else -> return null
         }
+    } else if (expression is IrGetEnumValue && type is IrSimpleType) {
+        // No need to check whether the type is serializable, that would throw an error somewhere else
+        val type: TypeName = (type as IrSimpleType).asTypeName()
+        val entry: String = expression.symbol.owner.name.asString()
+        return CodeBlock.of("%T.%N", type, entry)
     }
-    // risky option: take expression.dumpKotlinLike() as string.
     return null
 }
 

diff --git a/...sc/src/androidInstrumentedTest/kotlin/io/deepmedia/tools/knee/tests/DefaultValuesTests.kt b/...sc/src/androidInstrumentedTest/kotlin/io/deepmedia/tools/knee/tests/DefaultValuesTests.kt
@@ -26,4 +26,9 @@ class DefaultValuesTests {
         emptyStringDefaultValue()
     }
 
+    @Test
+    fun testDefaultValue_enum() {
+        enumDefaultValue()
+    }
+
 }
diff --git a/tests/test-misc/src/backendMain/kotlin/DefaultValuesDefinitions.kt b/tests/test-misc/src/backendMain/kotlin/DefaultValuesDefinitions.kt
@@ -22,4 +22,13 @@ interface BaseInterfaceWithDefaultValues {
 
 @Knee
 fun emptyStringDefaultValue(foo: String = "") {
+}
+
+@Knee
+fun enumDefaultValue(foo: DefaultValuesEnum = DefaultValuesEnum.First) {
+}
+
+@KneeEnum
+enum class DefaultValuesEnum {
+    First, Second
 }