Support for terminate request of debug adapter

deitry · Mar 4, 2021 · bc92d9c · bc92d9c
1 parent b45340c
commit bc92d9c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/Changelog.txt b/Changelog.txt
@@ -9,6 +9,7 @@ Changes
 3.0.4
 =====
  - Minor changes in exception handling to track down https://github.com/Unity-Technologies/vscode-unity-debug/issues/183
+ - More graceful debugger stop by supporting `terminate` request
 
 3.0.3
 =====

diff --git a/MonoDebug b/MonoDebug
diff --git a/UnityDebug/UnityDebugSession.cs b/UnityDebug/UnityDebugSession.cs
@@ -242,6 +242,8 @@ public override void Initialize(Response response, dynamic args)
 
                 supportsSetVariable = true,
 
+                supportsTerminateRequest = true,
+
                 // This debug adapter does not support exception breakpoint filters
                 exceptionBreakpointFilters = new ExceptionBreakpointsFilter[0]
             });

diff --git a/typescript/attach.ts b/typescript/attach.ts
@@ -103,6 +103,7 @@ function startSession(context: ExtensionContext, config: any) {
     let execCommand = "";
     if (process.platform !== 'win32')
         execCommand = "mono ";
+
     exec(execCommand + context.extensionPath + "/bin/UnityDebug.exe list", async function (error, stdout, stderr) {
         const processes = [];
         const lines = stdout.split("\n");
@@ -111,6 +112,7 @@ function startSession(context: ExtensionContext, config: any) {
                 processes.push(lines[i]);
             }
         }
+
         if (processes.length == 0) {
             window.showErrorMessage("No Unity Process Found.");
         } else {
@@ -125,7 +127,6 @@ function startSession(context: ExtensionContext, config: any) {
                 "__exceptionOptions": exceptions.convertToExceptionOptionsDefault()
             }
             let response = await debug.startDebugging(undefined, config);
-                    console.log("8");
 
             console.log("debug ended: " + response);
         }