Implement SDT Module #69
Conversation
RayLiu7
requested review from
Bhavneet-Sharma,
meenakshidembi691,
trisha-dell and
sachin-apa
as code owners
|
Can one of the admins verify this patch? |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 91.95% 92.05% +0.09%
==========================================
Files 49 52 +3
Lines 7311 7791 +480
Branches 919 961 +42
==========================================
+ Hits 6723 7172 +449
- Misses 309 325 +16
- Partials 279 294 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RayLiu7
force-pushed
the
sdt-module
branch
3 times, most recently
from
8ac8a88
to
052aff3
Compare
RayLiu7
force-pushed
the
sdt-module
branch
3 times, most recently
from
0d2df65
to
0bf699a
Compare
|
run e2e |
plugins/modules/sdt.py
Outdated
| sdt_ip_list = copy.deepcopy(sdt_params["sdt_ip_list"]) | ||
| if sdt_params["state"] == "present" and not sdt_details: | ||
| if sdt_params["sdt_new_name"] or sdt_params["maintenance_mode"]: | ||
| error_msg = "sdt_new_name and maintenance_mode are not supported during SDT creation" |
There was a problem hiding this comment.
We need to add support for renaming the sdt while create
There was a problem hiding this comment.
Hi @Bhavneet-Sharma, we had a agreement with Shrinidhi and Sachin to move modifying operations (like enter maintenance mode and rename) out of creation during the spike demo session, considering user usually have a sequence of steps to do in a playbook, so it's better to keep the atomicity of operations.
There was a problem hiding this comment.
Hi @RayLiu7,
We had review comment from Anupam to not to through an error message when rename parameter is passed while creating the object.
There was a problem hiding this comment.
@RayLiu7 its all about Declrative behavior, If we have enough data to perform an operation we should go ahead with it, instead of showing error, if it requires you to ignore certian paramters you can do that.
SO i think we need to remove this part to show error and just ignore the params not applicable for create.
There was a problem hiding this comment.
@sachin-apa @Bhavneet-Sharma ok, I'll remove the error display and ignore the params not applicable for create.
There was a problem hiding this comment.
@sachin-apa Just to confirm, by ignoring the params not for create, we don't perform the rename or mode change in the this task, right?
|
Sonar and Checkmarx report |
Description
Implement SDT Module
creating new SDT, getting details of SDT, managing IP/role of SDT,
modifying attributes of SDT, and deleting SDT.
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration