Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for Service Configuration for appliances #40

Conversation

Bhavneet-Sharma
Copy link
Collaborator

@Bhavneet-Sharma Bhavneet-Sharma commented Jan 17, 2024

Description

Adding Support for Service Configuration for appliances using service_config module

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Functional Test
  • Unit Test

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (61892f8) 88.69% compared to head (b2aca85) 88.68%.
Report is 4 commits behind head on main.

Files Patch % Lines
...dule_utils/storage/dell/libraries/configuration.py 71.42% 5 Missing and 3 partials ⚠️
plugins/modules/service_config.py 93.57% 2 Missing and 5 partials ⚠️
...le_utils/storage/dell/libraries/powerstore_base.py 93.93% 0 Missing and 2 partials ⚠️
...t/plugins/module_utils/mock_service_configs_api.py 93.75% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   88.69%   88.68%   -0.02%     
==========================================
  Files         109      114       +5     
  Lines       14787    15038     +251     
  Branches     1759     1789      +30     
==========================================
+ Hits        13116    13337     +221     
- Misses       1115     1127      +12     
- Partials      556      574      +18     
Flag Coverage Δ
units 88.68% <93.92%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

felixs88
felixs88 previously approved these changes Jan 24, 2024
@Bhavneet-Sharma Bhavneet-Sharma merged commit bf8fb2a into dell:main Jan 25, 2024
34 checks passed
@Bhavneet-Sharma Bhavneet-Sharma deleted the ANSBLTRID-1622-service-config-support branch January 25, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants