-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Support for Service Configuration for appliances #40
Merged
Bhavneet-Sharma
merged 9 commits into
dell:main
from
Bhavneet-Sharma:ANSBLTRID-1622-service-config-support
Jan 25, 2024
Merged
Adding Support for Service Configuration for appliances #40
Bhavneet-Sharma
merged 9 commits into
dell:main
from
Bhavneet-Sharma:ANSBLTRID-1622-service-config-support
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhavneet-Sharma
requested review from
kuttattz,
Jennifer-John,
meenakshidembi691,
Pavan-Mudunuri and
trisha-dell
as code owners
January 17, 2024 10:54
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 88.69% 88.68% -0.02%
==========================================
Files 109 114 +5
Lines 14787 15038 +251
Branches 1759 1789 +30
==========================================
+ Hits 13116 13337 +221
- Misses 1115 1127 +12
- Partials 556 574 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can one of the admins verify this patch? |
sachin-apa
approved these changes
Jan 24, 2024
felixs88
previously approved these changes
Jan 24, 2024
meenakshidembi691
previously approved these changes
Jan 24, 2024
trisha-dell
reviewed
Jan 25, 2024
trisha-dell
reviewed
Jan 25, 2024
trisha-dell
reviewed
Jan 25, 2024
trisha-dell
reviewed
Jan 25, 2024
Bhavneet-Sharma
dismissed stale reviews from meenakshidembi691 and felixs88
via
January 25, 2024 07:08
b2aca85
felixs88
approved these changes
Jan 25, 2024
trisha-dell
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Support for Service Configuration for appliances using service_config module
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration