feat(idrac_os_deployment): added support for ubuntu installation #784
Conversation
Sakethanne
requested review from
sachin-apa,
ABHISHEK-SINHA10,
Kritika-Bhateja-03,
rajshekarp87 and
ShivamSh3
as code owners
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
| @@ -0,0 +1,10 @@ | |||
| ubuntu_hostname: "ubuntu" | |||
| ubuntu_user_password: "$6$xlpCfETR.9nMepDn$0GDk0yuTOOMXrxFQacjQdbTNwCys.wMlo.EDzfKJGvLhy61R8IxaSCNveo247McGthyg7vBUgDlmTS3wF.64k1" # Initial user password (hashed using SHA-512) | |||
There was a problem hiding this comment.
Password should not be defaulted instead add a check in the commons/validate_inputs.yml to ensure user has given password as a input to the role for ubuntu
Else once installed they would not know what the password was.
| - uri: "http://archive.ubuntu.com/ubuntu" | ||
| arches: [i386, amd64] | ||
| - uri: "http://ports.ubuntu.com/ubuntu-ports" | ||
| arches: [s390x, arm64, armhf, powerpc, ppc64el, riscv64] |
There was a problem hiding this comment.
Good to move these to a vars as well. In a Data center sometimes they would not have access to the internet and want to use there own mirror.
sachin-apa
added
type/feature
| update: yes | ||
| apt: | ||
| preserve_sources_list: false | ||
| mirror-selection: |
There was a problem hiding this comment.
do we have to set this at all? maybe just remove this section and see if it works... ?
| @@ -423,7 +423,7 @@ Role Variables | |||
| </tr> | |||
| <tr> | |||
| <td>idrac_os_deployment_supported_os</td> | |||
| <td>{ RHEL: ["8", "9"], ESXI: ["8"] }</td> | |||
| <td>{ RHEL: ["8", "9"], ESXI: ["8"], UBUNTU: ["jammy"] }</td> | |||
There was a problem hiding this comment.
i wonder naming 22.04 vs jammy - what is better
https://wiki.ubuntu.com/Releases
There was a problem hiding this comment.
Since in the versioning format, he has not considered patch, both seems to be ok. Still if we have chanceof having different kickstsrt template based on versions, i would recommend to go with 22.04
Sakethanne
force-pushed
the
ubuntu_support
branch
3 times, most recently
from
2e74701 to
39be8ab
Compare
Signed-off-by: sakethanne <asvn.saketh@gmail.com>
Sakethanne
force-pushed
the
ubuntu_support
branch
from
39be8ab to
8a8e291
Compare
|
Have updated the code according to the comments and pushed them! |
| 1. Compile the iso to generate a custom iso by embedding the kickstart file in an iso using the `mkisofs`, `isohybrid` and `implantisomd5` commands. | ||
| 1. Copy the custom ISO generated to destination share location as specfied to the role input. Based on the input a following method is used to copy the destination to a shared repository. | ||
| 2. Create a kickstart file using jinja template based on the os name and version . | ||
| 3. Extract the ISO using the `xorriso` library, in case of ubuntu we use `7z`. |
There was a problem hiding this comment.
isn't it possible to use xorriso library for ubuntu too, as again we shall have new dependency on 7z, can you check and confirm once.
There was a problem hiding this comment.
@Sakethanne I see blog that is using xorriso with ubuntu
https://www.reddit.com/r/Ubuntu/comments/1cxotah/going_mad_cant_get_options_for_xorriso_to_work/
please try
There was a problem hiding this comment.
I was not able to acheive the same functionality with the xorisso command to unpack the ubuntu 22.04 version iso as compared to the 7z command.
The unpacked files were completely different between xorisso and 7z.
| @@ -37,14 +37,14 @@ argument_specs: | |||
| type: str | |||
| description: | |||
| - The operating system name to match the jinja template of the kickstart file. | |||
| - Supported os name is versions for RHEL and ESXI. | |||
| - Supported os name is versions for RHEL and ESXI and UBUNTU. | |||
There was a problem hiding this comment.
| - Supported os name is versions for RHEL and ESXI and UBUNTU. | |
| - Supported os name is versions for RHEL, ESXI and UBUNTU. |
| - Jinja template file should exists in the format <os_name_upper>_<os_version_major>.j2 | ||
| - This is required when I(is_custom_iso) is C(false). | ||
| os_version: | ||
| type: str | ||
| description: | ||
| - The operating system version to match the jinja template of the kickstart file. | ||
| - Supported versions for RHEL are 9.x and 8.x and for ESXi is 8.x. | ||
| - Supported versions for RHEL are 9.x and 8.x and for ESXi is 8.x and for UBUNTU is jammy. |
There was a problem hiding this comment.
| - Supported versions for RHEL are 9.x and 8.x and for ESXi is 8.x and for UBUNTU is jammy. | |
| - Supported versions for RHEL are 9.x and 8.x, for ESXi is 8.x and for UBUNTU is jammy. |
Description
This pull request extends the functionality of the idrac_os_deployment Ansible role to provide native support for Ubuntu Jammy (Ubuntu 22.04 LTS). This includes updates to the OS detection logic, modifications to ensure compatibility with the iDRAC OS deployment process, and test validation for seamless integration.
The enhancements address the gap in supporting newer Ubuntu versions, aligning the role with modern deployment requirements.
GitHub Issues
List the GitHub issues impacted by this PR: #780
Currently only RHEL and EXSI have native support for the idrac_os_deployment role and it currently does not have native support for the Ubuntu OS. | #780
ISSUE TYPE
COMPONENT NAME
Role: idrac_os_deployment
OUTPUT
ADDITIONAL INFORMATION
The changes resolve the inability of the idrac_os_deployment role to recognize and process Ubuntu Jammy 22.04.
Key Updates:
Enhanced the OS detection mechanism to include Ubuntu Jammy 22.04.
Adjusted playbook logic to handle the differences in OS setup for Jammy compared to older Ubuntu versions.
Updated documentation to include instructions for deploying Ubuntu 22.04.
Checklist: