Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/faucet page #559

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Refactor/faucet page #559

merged 6 commits into from
Oct 30, 2024

Conversation

oceanByte
Copy link
Contributor

Fixes requested changes from #555

Proposed Changes

  • Renamed component and related references from Verify to Faucet
  • Moved static content to faucet.json
  • Refactored the FaucetPage component to use wagmi hooks for account, network info and for signing messages

@oceanByte oceanByte added the Priority: Low Don't work on this unless everything else is done label Aug 6, 2024
Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mvg-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:45pm

src/components/Faucet/index.tsx Outdated Show resolved Hide resolved
src/components/Faucet/index.tsx Outdated Show resolved Hide resolved
@moritzkirstein moritzkirstein changed the base branch from main to development October 30, 2024 21:32
@moritzkirstein moritzkirstein requested a review from a team as a code owner October 30, 2024 21:32
@moritzkirstein moritzkirstein merged commit f61d269 into development Oct 30, 2024
8 of 9 checks passed
@moritzkirstein moritzkirstein deleted the refactor/faucet-page branch October 30, 2024 21:47
moritzkirstein added a commit that referenced this pull request Oct 31, 2024
* refactor(faucet): rename Verify to Faucet

* refactor(faucet): extract faucet content to faucet.json

* refactor: use wagmi instead of ethers

* refactor: rename function to PageFaucet()

* refactor(faucet): update Content interface

* refactor: use NetworkName

---------

Co-authored-by: Moritz Kirstein <mkirstein@protonmail.com>
moritzkirstein added a commit that referenced this pull request Nov 11, 2024
* refactor(faucet): rename Verify to Faucet

* refactor(faucet): extract faucet content to faucet.json

* refactor: use wagmi instead of ethers

* refactor: rename function to PageFaucet()

* refactor(faucet): update Content interface

* refactor: use NetworkName

---------

Co-authored-by: Moritz Kirstein <mkirstein@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Don't work on this unless everything else is done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants