Fix: Dont overwrite equal drafts #6212
Conversation
src/chat.rs
Outdated
| let self_chat = alice.get_self_chat().await.id; | ||
| self_chat.set_draft(&alice, Some(&mut msg)).await.unwrap(); | ||
| let draft1 = self_chat.get_draft(&alice).await?.unwrap(); | ||
| tokio::time::sleep(Duration::from_millis(800)).await; |
There was a problem hiding this comment.
Could use SystemTime::shift?
|
Ah true, quote should probably also be checked. We definitely need to update but maybe we can just update the quote and don't touch timestamp. |
Co-authored-by: l <link2xt@testrun.org>
Co-authored-by: l <link2xt@testrun.org>
Septias
force-pushed
the
sk/dont_overwrite_eq_draft
branch
from
48cc5a3
to
9bcd84b
Compare
Why not change the timestamp if the quote is updated? Instead of all these checks that need to be synchronized, can |
|
Another option is to make it a transaction which first updates everything except the timestamp and if the number of changed rows != 0, updates the timestamp as well. |
src/chat.rs
Outdated
| ), | ||
| )?; | ||
| if affected_rows > 0 { | ||
| transaction.execute("UPDATE msgs SET timestamp=? WHERE id=?;", (time(),msg.id))?; |
There was a problem hiding this comment.
Could update the timestamp in the same UPDATE above.
There was a problem hiding this comment.
but then we would anyways update the timestamp and hence move that chat to the top, exactly what we are trying to avoid?
There was a problem hiding this comment.
Not if there is a WHERE check.
src/chat.rs
Outdated
| ) | ||
| .await?; | ||
| return Ok(true); | ||
| .transaction(|transaction| { |
There was a problem hiding this comment.
There is no need for transaction anymore.
| msg.id, | ||
| ), | ||
| ).await?; | ||
| if affected_rows > 0 { |
There was a problem hiding this comment.
return Ok(affected_rows > 0)
This PR prevents overwriting drafts when the text and file are the same.
close #6211