You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Search for usages of dc_msg_get_file() (C-FFI) / MessageObject.file (JsonRPC), check where it's passed, and make sure that all it's never used to check the file extension, to pass it to an external application, or to show it to the user.
Look at places in the code where a filename is user-visible, like when viewing it in the UI or passing it to an external application (especially when sharing or opening it). Check where the filename comes from, and make sure that it comes from dc_msg_get_filename(), not from dc_msg_get_file().
Test that
sharing to and from DC
opening
saving ("Export attachment")
drafting and re-entering the chat
opening the drafted file once more
sending
still works for a) Images b) Videos c) vCards (attached contacts) d) attached files e) webxdc's. Also that editing and previewing drafted images works, and that previewing drafted videos works. (I hope I didn't forget to test any combination)
Then iOS will be ready for using core with deltachat/deltachat-core-rust#6332 merged. Received files will be deduplicated then, but outgoing files not yet.
We want to deduplicate blob files by always setting the file name to be the hash of the file content. Core issue: deltachat/deltachat-core-rust#6265, core PR: deltachat/deltachat-core-rust#6332
To be done:
dc_msg_get_filename()
(C-FFI) orMessageObject.file_name
(JsonRPC) needs to be used, similar to the Android PR at fix: Use getFilename() instead of the actual filename on disk deltachat-android#3521.dc_msg_get_file()
(C-FFI) /MessageObject.file
(JsonRPC), check where it's passed, and make sure that all it's never used to check the file extension, to pass it to an external application, or to show it to the user.dc_msg_get_filename()
, not fromdc_msg_get_file()
.sharing to and from DC
opening
saving ("Export attachment")
drafting and re-entering the chat
opening the drafted file once more
sending
still works for a) Images b) Videos c) vCards (attached contacts) d) attached files e) webxdc's. Also that editing and previewing drafted images works, and that previewing drafted videos works. (I hope I didn't forget to test any combination)
Then iOS will be ready for using core with deltachat/deltachat-core-rust#6332 merged. Received files will be deduplicated then, but outgoing files not yet.
dc_msg_set_file_and_deduplicate()
instead ofdc_msg_set_file()
If all of this becomes too complicated, tell me, we can also change how files are deduplicated a bit.
The text was updated successfully, but these errors were encountered: