refactor(type_de_champ): cleanup type predicate methods #11029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11029 +/- ##
==========================================
- Coverage 84.52% 84.49% -0.04%
==========================================
Files 1163 1163
Lines 25730 25684 -46
Branches 4857 4857
==========================================
- Hits 21749 21701 -48
- Misses 3981 3983 +2 ☔ View full report in Codecov by Sentry. |
tchak
force-pushed
the
refactor-type-de-champ-predicates
branch
2 times, most recently
from
c2c3bab
to
7be4f90
Compare
LeSim
reviewed
Nov 12, 2024
app/components/types_de_champ_editor/champ_component/champ_component.html.haml
Show resolved
Hide resolved
tchak
force-pushed
the
refactor-type-de-champ-predicates
branch
from
7be4f90
to
fb8eeed
Compare
tchak
force-pushed
the
refactor-type-de-champ-predicates
branch
from
fb8eeed
to
dc6bad4
Compare
LeSim
approved these changes
Nov 12, 2024
| @@ -66,7 +66,7 @@ class TypeDeChamp < ApplicationRecord | |||
| expression_reguliere: STANDARD | |||
| } | |||
|
|
|||
| enum type_champs: { | |||
| enum type_champ: { | |||
Merged
via the queue into
demarches-simplifiees:main
with commit Nov 12, 2024
8db85b4
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.