Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cs falcon status update #35750

Merged
merged 11 commits into from
Aug 5, 2024
Merged

Cs falcon status update #35750

merged 11 commits into from
Aug 5, 2024

Conversation

Shellyber
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: XSUP-39445

Description

  • Changed the call of get_status to run in batches instead of one call for each device id.
  • Some code cleanup

Must have

  • Tests

Copy link

github-actions bot commented Aug 4, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon
   CrowdStrikeFalcon.py294273475%459, 484, 524, 536, 570–571, 573–574, 592, 758–760, 775, 778, 806–815, 836, 911, 949–950, 952, 955–957, 1005, 1035, 1094–1095, 1097, 1102, 1105–1106, 1121–1123, 1128, 1131–1132, 1147–1148, 1150, 1155, 1158–1159, 1187, 1189, 1194–1195, 1205, 1207, 1212–1213, 1323, 1444, 1446, 1474, 1476, 1498–1501, 1535, 1585, 1589, 1691, 1703–1704, 1706–1707, 1710, 1712, 1716–1717, 1753, 1762, 1767, 1796, 1798, 1826, 1830, 1862, 1864, 1994, 2000, 2011–2014, 2023–2027, 2081, 2085, 2094, 2097–2098, 2101, 2110, 2113–2114, 2117, 2133, 2165, 2171–2174, 2177, 2181, 2233–2234, 2236, 2240, 2243, 2246, 2250–2251, 2254, 2269, 2428–2432, 2434–2438, 2442, 2445, 2448–2449, 2452–2454, 2456, 2465, 2467, 2685, 2690, 2694, 2735–2738, 2741, 2744, 2746–2747, 2790–2792, 2795–2797, 2799, 2820, 2912, 2938–2939, 2998–2999, 3047, 3125–3128, 3130, 3170, 3173, 3356–3357, 3542, 3646–3647, 3649, 3687–3692, 3742–3745, 3814, 3821, 3859, 3948, 3963, 3981, 3995, 4009–4012, 4025–4029, 4031–4032, 4034–4035, 4043–4051, 4073, 4115, 4121, 4156–4164, 4166–4167, 4175–4188, 4190–4191, 4193, 4195–4196, 4198–4200, 4202–4205, 4207, 4209, 4211, 4223–4231, 4233–4246, 4254–4257, 4265–4268, 4304–4307, 4326–4331, 4333–4334, 4336–4343, 4353–4354, 4357, 4573–4575, 4582, 4604–4607, 4619, 4650–4653, 4669, 4701–4704, 4724–4725, 4735, 4748–4749, 4751, 4760–4763, 4804–4805, 4823–4826, 4871–4874, 4906, 4911–4912, 4954, 4956–4957, 4997–4998, 5004, 5025–5026, 5042–5043, 5058, 5072, 5075–5076, 5084, 5087–5088, 5099, 5103, 5142–5144, 5152–5154, 5156, 5183–5192, 5223, 5290–5293, 5296–5297, 5301–5304, 5307–5308, 5317–5318, 5320, 5322, 5324, 5326–5328, 5332, 5346–5350, 5415–5417, 5419, 5422, 5424, 5427, 5429–5431, 5433, 5435–5436, 5440–5444, 5449, 5451–5452, 5456–5457, 5459–5463, 5467, 5527, 5630, 5972, 5983, 6054, 6056, 6065, 6071, 6138, 6145, 6150, 6152, 6162, 6168, 6173, 6175–6176, 6178–6180, 6182, 6190, 6208, 6217, 6223, 6241, 6249, 6254, 6256–6257, 6259–6261, 6263, 6271, 6301, 6307, 6312, 6314, 6323, 6329, 6334, 6336–6337, 6339–6341, 6343, 6351, 6405, 6407–6408, 6410–6411, 6413, 6457–6458, 6460–6461, 6468, 6470, 6475, 6554, 6583–6584, 6592–6593, 6597, 6661, 6713, 6766, 6890, 6964–6965, 6967, 6969, 6986–6988, 6990–6995, 6997–7060, 7062–7073, 7080–7093, 7095–7096, 7098–7099, 7107–7108, 7110–7111, 7113–7114, 7116–7117, 7119–7123, 7127–7131, 7135–7136, 7138–7143, 7145–7148, 7150–7199, 7201–7216, 7218, 7220–7221
TOTAL294273475% 

Tests Skipped Failures Errors Time
1062 0 💤 0 ❌ 0 🔥 17.755s ⏱️

Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@Shellyber Shellyber merged commit 2e67939 into master Aug 5, 2024
16 checks passed
@Shellyber Shellyber deleted the cs-falcon-status-update branch August 5, 2024 16:54
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
* Enhanced get_status function

* added test

* Added release notes

* Resolve conflict

* Update docker image

* CR fixes

* pre-commit

* Update docker - again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants