Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP Command for the Spur Context API Integration #36466

Open
wants to merge 27 commits into
base: contrib/defendable-sokrates_spur_context_api_ip_command
Choose a base branch
from

Conversation

defendable-sokrates
Copy link

@defendable-sokrates defendable-sokrates commented Sep 24, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Added the IP reputation command to the Spur Context API integration.

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2024

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Sep 24, 2024
@content-bot content-bot changed the base branch from master to contrib/defendable-sokrates_spur_context_api_ip_command September 24, 2024 12:44
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @rshunim will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @defendable-sokrates, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Sep 24, 2024
defendable-sokrates and others added 2 commits October 1, 2024 11:02
Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
Comment on lines 230 to 234
return_results(ip_command(client, demisto.args()))
elif command == "spur-context-api-enrich":
return_results(enrich_command(client, demisto.args()))

# Log exceptions and return errors
except Exception:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return_results(ip_command(client, demisto.args()))
elif command == "spur-context-api-enrich":
return_results(enrich_command(client, demisto.args()))
# Log exceptions and return errors
except Exception:
elif command == "ip":
return_results(ip_command(client, demisto.args()))
elif command == "spur-context-api-enrich":
return_results(enrich_command(client, demisto.args()))

Comment on lines 225 to 226

elif demisto.command() == 'spur-context-api-enrich':
return_results(enrich_command(client, demisto.args()))
if command == "test-module":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elif demisto.command() == 'spur-context-api-enrich':
return_results(enrich_command(client, demisto.args()))
if command == "test-module":

Copy link
Contributor

@yaakovpraisler yaakovpraisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @defendable-sokrates, Thank you for your contribution!
Please follow my comments below.

Also. let's schedule a short call for a demo.

defendable-sokrates and others added 2 commits October 1, 2024 13:02
…I.py

Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
@defendable-sokrates
Copy link
Author

defendable-sokrates commented Oct 1, 2024

Hey @defendable-sokrates, Thank you for your contribution! Please follow my comments below.

Also. let's schedule a short call for a demo.

Hello @yaakovpraisler,
Sounds good, how do we go about scheduling the call?

Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner-Approved pending-demo Demo pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants