Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Indicators From File PB: not convert docx to pdf #36573

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ilappe
Copy link
Contributor

@ilappe ilappe commented Oct 1, 2024

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-41176

Description

currently, we consider a file which contain xml in the file.info - as file to be converted to pdf
this lead to convert also a docx file with vnd.openxmlformats-officedocument.wordprocessingml.document in the file.info

adding additional check to filter out doc/docx files

@ilappe ilappe self-assigned this Oct 1, 2024
Copy link
Contributor

@idovandijk idovandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, but we also need to add the same filter to the conversion task (not just the conditional task), otherwise the condition may pass (due to other supported files), and then the conversion will run (against both supported and unsupported files)

@ilappe ilappe requested a review from idovandijk October 1, 2024 11:02
Copy link
Contributor

@idovandijk idovandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants