[XDR - IR] revert #35932 #36580
Merged
[XDR - IR] revert #35932 #36580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
||||||||||||||||||||||||||||||
YuvHayun
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Looks good.
approved for my side.
Just note the comments about the RN.
Make sure @JudahSchwartz also review it.
|
|
||
| ##### Palo Alto Networks Cortex XDR - Investigation and Response | ||
|
|
||
| - Reverting the de-duplication mechanism added in version `6.1.73`. |
There was a problem hiding this comment.
This RN should be "fixed an issue where - {the issue}"
Additionally, add a note inside 6.1.73 RN that the version is invalid (like the example I sent on slack)
| @@ -70,52 +70,6 @@ | |||
| }, | |||
| { | |||
| "incident_id": "4", | |||
| "creation_time": 100000001, | |||
| "modification_time": 1575813875168, | |||
There was a problem hiding this comment.
Is it really necessary to revert here?
There was a problem hiding this comment.
it will make it easier for me to unrevert
JudahSchwartz
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes:
Description
Revert version
6.1.73in #35932.Must have