V3 actual consistent naming #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
dennwc
reviewed
Oct 17, 2018
bblfsh/pyuast.cc
Outdated
| return node->ctx->Iterate(obj, (TreeOrder)order); | ||
| } | ||
| // Python object -> create a new context and attach it to an iterator | ||
| Context* ctx = new Context(); | ||
| return ctx->Iterate(obj, (TreeOrder)order, true); | ||
| } | ||
|
|
||
| static PyObject *PyUastDecode(PyObject *self, PyObject *args) { | ||
| static PyObject *PyContextDecode(PyObject *self, PyObject *args) { |
There was a problem hiding this comment.
Py_Decode, since it's a global method, or PyContextExt_decode since it's a constructor specifically for PyContextExt
There was a problem hiding this comment.
👍 this is a perfect example how we could benefit from new github feature :) https://blog.github.com/category/all/#suggested-changes-public-beta
bzz
commented
Oct 17, 2018
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring for clarity and consistency, as discussed IRL:
Part of the bblfsh#128