-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): handle edge cases around export
s in doc tests and default export
#25720
Merged
+214
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@iuioiua FYI, with this patch the result of running
This failure makes sense to me |
Agreed. I |
marvinhagemeister
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issues with the pseudo test file generation logic, namely:
export
s declared in snippetsdefault export
Case 1:
export
s declared in snippetsIn the previous implementation,
export
s declared in snippets were moved to the top level of the module in the generated pseudo test file. This is required becauseexport
must be at the top level.This becomes a problem if such a
export
has a body, containing a reference to a local variable. Suppose we extract this snippet from JSDoc:This gets converted into the following invalid code (note that
export function sum
is moved to the top level, but its body referenceslogger
variable which can't be referenced from here):To resolve this issue, this commit adds a logic to remove the
export
keyword, allowing the exported items to stay in theDeno.test
block scope, like so:Case 2: default export
Previously
default export foo
was not captured by the export collector, so auto import insertion didn't work for this case. To put it concretely, the following code snippet didn't work when run withdeno test --doc
becauseimport foo from "file:///path/to/mod.ts"
didn't get inserted automatically:This commit fixes this issue and the above example works fine.
Fixes #25718